Differential D4073

deposit*: Rename internally swh_id references to swhid
ClosedPublic
Actions

Authored by ardumont on Sep 29 2020, 11:01 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDDEP4d72d1be529a: deposit*: Rename internally swh_id references to swhid

Summary

This is an internal change only. The existing xml still references the old name.

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 29 2020, 11:01 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 29 2020, 11:01 AM

Build is green

Patch application report for D4073 (id=14377)

Rebasing onto a2830a9b0b...

Current branch diff-target is up to date.

Changes applied before test

commit 08c1e742884862f144a08d3d64a6ee888e1d5aa2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 29 10:56:39 2020 +0200

    deposit*: Rename internally swh_id references to swhid
    
    This is an internal change only. The existing xml still references the old name
    though.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/162/ for more details.

Harbormaster completed remote builds in B15673: Diff 14377.Sep 29 2020, 11:04 AM

vlorentz accepted this revision.Sep 29 2020, 11:05 AM

This revision is now accepted and ready to land.Sep 29 2020, 11:05 AM

ardumont edited the summary of this revision. (Show Details)Sep 29 2020, 11:10 AM

Fix deposit client part (this parses the unchanged xml output so the fields should stay the old names)

Build is green

Patch application report for D4073 (id=14378)

Rebasing onto a2830a9b0b...

Current branch diff-target is up to date.

Changes applied before test

commit 4d72d1be529a568784842f5c0864e862a4b4705c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 29 10:56:39 2020 +0200

    deposit*: Rename internally swh_id references to swhid
    
    This is an internal change only. The existing xml still references the old name
    though.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/163/ for more details.

Harbormaster completed remote builds in B15674: Diff 14378.Sep 29 2020, 11:18 AM

Closed by commit rDDEP4d72d1be529a: deposit*: Rename internally swh_id references to swhid (authored by ardumont). · Explain WhySep 29 2020, 12:05 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEP4d72d1be529a: deposit*: Rename internally swh_id references to swhid.