Page MenuHomeSoftware Heritage

Output a warning when the version of the database is different than expected
ClosedPublic

Authored by olasd on Sep 24 2020, 1:56 PM.

Details

Summary

When running tests, and dbversion and db.current_version do not match,
we get an arcane check_config failure. At least this log line can help a little
to understand what is going on.

Test Plan

Running tests on D3981 with this diff gives a more understandable
failure.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont added a subscriber: ardumont.

lgtm

I got bitten by this yesterday (thus the schema table name change because of
clash of tables dbversion...).

This was this check which failed but i had to debug it indeed to actually see
the problem (P773).

It did not occur to me to change that... So yeah, good idea!

(I recall there is a test for it)

Thanks.

This revision is now accepted and ready to land.Sep 24 2020, 2:15 PM

Build was aborted

Patch application report for D4031 (id=14220)

Rebasing onto e37f63930b...

Current branch diff-target is up to date.
Changes applied before test
commit 38b1dbf38c3d1b0e008fd0c7e6942f7e1300518f
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Sep 24 13:53:55 2020 +0200

    Output a warning when the version of the database is different than expected

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/971/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/971/console

Build is green

Patch application report for D4031 (id=14220)

Rebasing onto e37f63930b...

Current branch diff-target is up to date.
Changes applied before test
commit 38b1dbf38c3d1b0e008fd0c7e6942f7e1300518f
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Sep 24 13:53:55 2020 +0200

    Output a warning when the version of the database is different than expected

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/973/ for more details.