Differential D4029

Attempt to fix dependency-related hell in tox
ClosedPublic
Actions

Authored by douardda on Sep 24 2020, 11:13 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDDEP047588a03f0b: Fix dependency-related hell in tox

Summary

Fixes jenkins build [1]

[1] https://jenkins.softwareheritage.org/job/DDEP/job/tests/974/console

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Sep 24 2020, 11:13 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 24 2020, 11:13 AM

commit message! ;)

This revision is now accepted and ready to land.Sep 24 2020, 11:14 AM

Build is green

Patch application report for D4029 (id=14211)

Rebasing onto 3416abd010...

Current branch diff-target is up to date.

Changes applied before test

commit 194068fd4b9745676d061439b7893dbfa6d9f661
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 24 11:12:39 2020 +0200

    Attempt to fix dependency-related hell in tox

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/110/ for more details.

Harbormaster completed remote builds in B15486: Diff 14211.Sep 24 2020, 11:16 AM

In D4029#99626, @vlorentz wrote:

commit message! ;)

yeah I first wanted to see whether it's a fix or not, now I can amend to a (possibly) better one

ardumont edited the summary of this revision. (Show Details)Sep 24 2020, 11:20 AM

update ci message

This revision was landed with ongoing or failed builds.Sep 24 2020, 11:26 AM

Closed by commit rDDEP047588a03f0b: Fix dependency-related hell in tox (authored by douardda). · Explain Why

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDDEP047588a03f0b: Fix dependency-related hell in tox.

Build is green

Patch application report for D4029 (id=14213)

Rebasing onto 3416abd010...

Current branch diff-target is up to date.

Changes applied before test

commit 047588a03f0bbad4f91e7de722c7502a2596ecbc
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 24 11:12:39 2020 +0200

    Fix dependency-related hell in tox
    
    For some reason, the previous commit ended up messing pip while
    selecting the extras of swh.core to be used, making it not select the
    [http] extra.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/111/ for more details.

Harbormaster completed remote builds in B15488: Diff 14213.Sep 24 2020, 11:28 AM