Docker: Migrate relevant services to the split `swh db create` / `swh db init`
ClosedPublic
Actions

Authored by olasd on Sep 23 2020, 7:59 PM.

Details

Reviewers

douardda
ardumont

Commits

rDENV4c07a0d178ff: Migrate relevant services to the split `swh db create` / `swh db init`

Summary

Since swh.core 0.3.0, the database creation (superuser) and database
initialization (user) operations have been split for databases managed using raw
SQL.

Override the postgresql containers for these services to avoid creating an

empty database.

Add an entry for the template1 database to .pgpass so other containers can

connect to it

extend wait_pgsql to take a database name as first argument

Test Plan

cleaned up all containers, rebuilt swh/stack and ran tox in the
docker directory, to successful completion.

Diff Detail

Repository

rDENV Development environment

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Sep 23 2020, 7:59 PM

Harbormaster completed remote builds in B15474: Diff 14200.Sep 23 2020, 7:59 PM

lgtm

Plus, tryout run executed up to a loading and browsing in webapp -> everything is fine!

Note: And other dbs (listers, deposit, webapp...) are not impacted by this
change because those other associated entrypoints have their own ways of
initializing dbs... just saying because i was not remembering exactly and had to check ;)

Thanks.

This revision is now accepted and ready to land.Sep 24 2020, 10:15 AM

olasd added a child revision: D4030: Add an optional swh.storage read replica to the docker setup.Sep 24 2020, 12:53 PM

thx a lot

Closed by commit rDENV4c07a0d178ff: Migrate relevant services to the split `swh db create` / `swh db init` (authored by olasd). · Explain WhySep 24 2020, 4:10 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDENV4c07a0d178ff: Migrate relevant services to the split `swh db create` / `swh db init`.