pre-commit: Update flake8 hook configuration
ClosedPublic
Actions

Authored by anlambert on Sep 17 2020, 11:12 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS91569bf6b094: pre-commit: Update flake8 hook configuration

Summary

flake8 hook has been removed from https://github.com/pre-commit/pre-commit-hooks
so now use the one from https://gitlab.com/pycqa/flake8

See error output below after executing pre-commit autoupdate:

pre-commit run --all-files
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/codespell-project/codespell.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/python/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Trim Trailing Whitespace.................................................Passed
Flake8 (removed).........................................................Failed
- hook id: flake8
- exit code: 1

`flake8` has been removed -- use `flake8` from https://gitlab.com/pycqa/flake8

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Sep 17 2020, 11:12 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 17 2020, 11:12 AM

Build is green

Patch application report for D3971 (id=13997)

Rebasing onto cec8f16fe0...

Current branch diff-target is up to date.

Changes applied before test

commit 91569bf6b094a88d7f4557dc47332b3917ef8394
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Sep 17 11:10:06 2020 +0200

    pre-commit: Update flake8 hook configuration
    
    flake8 hook has been removed from https://github.com/pre-commit/pre-commit-hooks
    so now use the one from https://gitlab.com/pycqa/flake8

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/372/ for more details.

Harbormaster completed remote builds in B15208: Diff 13997.Sep 17 2020, 11:19 AM

anlambert added a child revision: D3972: pre-commit: Add isort hook and configuration.Sep 17 2020, 11:20 AM

lgtm, we most probably need to do that everywhere now though.

This revision is now accepted and ready to land.Sep 17 2020, 12:18 PM

In D3971#98016, @ardumont wrote:

lgtm, we most probably need to do that everywhere now though.

Ack, I will do it in one batch using the change-all-repos script from @vlorentz .

Closed by commit rDWAPPS91569bf6b094: pre-commit: Update flake8 hook configuration (authored by anlambert). · Explain WhySep 17 2020, 1:51 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS91569bf6b094: pre-commit: Update flake8 hook configuration.

In D3971#98057, @anlambert wrote:

In D3971#98016, @ardumont wrote:

lgtm, we most probably need to do that everywhere now though.

Ack, I will do it in one batch using the change-all-repos script from @vlorentz .