Paths

Table of Contentst

Differential D3964

swh.core.config: Drop support for ini configuration file
ClosedPublic
Actions

Authored by ardumont on Sep 16 2020, 2:32 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T1532: Cleanup deprecated configuration code in swh modules

Commits

rDCORE66ac6ed3aa31: swh.core.config: Drop support for ini configuration file

Summary

This is no longer used [1]

This also adds some types on impacted changed functions.

[1] Historically, we started using .ini file as configuration file for swh.
We moved to yaml a while ago. Only one last instance of it is currently
getting rid of in D3963.

Related to T1532
Related to D3963

Test Plan

tox

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15165
Build 23379: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 23378: arc lint + arc unit

Event Timeline

ardumont created this revision.Sep 16 2020, 2:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 16 2020, 2:32 PM

Build is green

Patch application report for D3964 (id=13953)

Rebasing onto 60c535ddee...

Current branch diff-target is up to date.

Changes applied before test

commit a7dec76d7139ee6c3398c47d4215b2cbbd19d07f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 14:32:19 2020 +0200

    swh.core.config: Drop support for ini configuration file
    
    This is no longer used.
    
    This also adds some types on impacted changed functions.
    
    Related to T1532

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/42/ for more details.

Harbormaster completed remote builds in B15165: Diff 13953.Sep 16 2020, 2:33 PM

ardumont edited the summary of this revision. (Show Details)Sep 16 2020, 2:33 PM

ardumont added a project: Core & foundations.

ardumont added inline comments.Sep 16 2020, 2:36 PM

swh/core/config.py
131	Should be `return conf`. Fixing it and adding a test for it.

ardumont edited the summary of this revision. (Show Details)Sep 16 2020, 2:36 PM

Fix and add tests about edge case (no default config provided during read call)

Build is green

Patch application report for D3964 (id=13955)

Rebasing onto 60c535ddee...

Current branch diff-target is up to date.

Changes applied before test

commit 5efe22dec6debdcd27fe10abaef3094b9fbdf69a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 14:32:19 2020 +0200

    swh.core.config: Drop support for ini configuration file
    
    This is no longer used.
    
    This also adds some types on impacted changed functions.
    
    Related to T1532

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/43/ for more details.

Harbormaster completed remote builds in B15167: Diff 13955.Sep 16 2020, 2:46 PM

ardumont added inline comments.Sep 16 2020, 2:48 PM

swh/core/config.py
28	This needs to get dropped as well indeed! [1] D3963#97708

Drop unnecessary default configuration about log_db

Build is green

Patch application report for D3964 (id=13956)

Rebasing onto 60c535ddee...

Current branch diff-target is up to date.

Changes applied before test

commit 66ac6ed3aa31a63da3226f2857755f7398721d31
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 14:32:19 2020 +0200

    swh.core.config: Drop support for ini configuration file
    
    This is no longer used.
    
    This also adds some types on impacted changed functions.
    
    Related to T1532

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/44/ for more details.

Harbormaster completed remote builds in B15168: Diff 13956.Sep 16 2020, 2:50 PM

vlorentz accepted this revision.Sep 16 2020, 4:23 PM

This revision is now accepted and ready to land.Sep 16 2020, 4:23 PM

Closed by commit rDCORE66ac6ed3aa31: swh.core.config: Drop support for ini configuration file (authored by ardumont). · Explain WhySep 16 2020, 4:27 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCORE66ac6ed3aa31: swh.core.config: Drop support for ini configuration file.