Page MenuHomeSoftware Heritage

migrate_extrinsic_metadata.test_pypi: use the in-memory storage instead of mocks
ClosedPublic

Authored by vlorentz on Wed, Sep 16, 10:43 AM.

Details

Summary

in a future commit, migrating pypi revisions will become more interactive with
the storage, so it's easier to have a real one instead of a mock.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Wed, Sep 16, 10:43 AM

Build is green

Patch application report for D3958 (id=13937)

Could not rebase; Attempt merge onto 3b781a8a52...

Merge made by the 'recursive' strategy.
 swh/storage/migrate_extrinsic_metadata.py          | 102 ++++++-
 .../migrate_extrinsic_metadata/test_debian.py      | 308 ++++++++++++++++++++-
 .../tests/migrate_extrinsic_metadata/test_pypi.py  | 246 ++++++++--------
 3 files changed, 523 insertions(+), 133 deletions(-)
Changes applied before test
commit d91705aaf0b32ed22f1685b5b7cf9baeaca0ce9b
Merge: 3b781a8a 8e8c7ee7
Author: Jenkins user <jenkins@localhost>
Date:   Wed Sep 16 08:43:51 2020 +0000

    Merge branch 'diff-target' into HEAD

commit 8e8c7ee79a832e59a20ff894299b58024addd967
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Sep 16 09:50:08 2020 +0200

    migrate_extrinsic_metadata.test_pypi: use the in-memory storage instead of mocks
    
    in a future commit, migrating pypi revisions will become more interactive with
    the storage, so it's easier to have a real one instead of a mock.

commit f6943400ff48ba840ab604747252ad4197fab5d9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 10:51:48 2020 +0200

    migrate_extrinsic_metadata.test_debian: use the in-memory storage instead of mocks
    
    in tests that need to read in the storage.
    
    Using mocks just makes it more complicated, and we decided not to do that
    a while ago.

commit 7a0467972fcd0c05ff16d806b18261aba8624288
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 11 14:16:21 2020 +0200

    migrate_extrinsic_metadata: fix crash on dangling branch.

commit 7969d368966c43ebfd51b2901c827217b0712dd5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 11 13:59:55 2020 +0200

    migrate_extrinsic_metadata: fix crash when a Debian revision is missing.
    
    https://forge.softwareheritage.org/T997

commit 265fc387f7b3d5f1a55d136b74fa2ee9b9f11f58
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 10 14:23:12 2020 +0200

    migrate_extrinsic_metadata: guess Debian origins.
    
    This works by guessing the package name from the original_artifact data,
    then building origins that would match the package name, then filtering
    out origins by checking if the revision can be reached from them.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/933/ for more details.

ardumont accepted this revision.Wed, Sep 16, 2:47 PM
This revision is now accepted and ready to land.Wed, Sep 16, 2:47 PM
This revision was landed with ongoing or failed builds.Wed, Sep 16, 5:02 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D3958 (id=13973)

Rebasing onto f008a597fd...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-943-D3958.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/943/ for more details.