Differential D3952

common/origin_save: Improve test for finding a visit date
ClosedPublic
Actions

Authored by anlambert on Sep 15 2020, 1:16 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS24950a876c44: common/origin_save: Improve test for finding a visit date

Summary

When trying to associate a visit date to an origin save request, only consider
visits with partial or full statuses as no snapshots will be present for other
ones (e.g. created, ongoing).

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Sep 15 2020, 1:16 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 15 2020, 1:16 PM

Build is green

Patch application report for D3952 (id=13903)

Rebasing onto 16ab03ab45...

Current branch diff-target is up to date.

Changes applied before test

commit 8660390ac95daf876594bd8bacf1d4abcb167391
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Sep 15 11:44:07 2020 +0200

    common/origin_save: Improve test for finding a visit date
    
    When trying to associate a visit date to an origin save request, only consider
    visits with partial or full statuses as no snapshots will be present for other
    ones (e.g. created, ongoing).

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/364/ for more details.

Harbormaster completed remote builds in B15127: Diff 13903.Sep 15 2020, 1:23 PM

Rebase

Build is green

Patch application report for D3952 (id=13905)

Rebasing onto 37cd0a8bce...

Current branch diff-target is up to date.

Changes applied before test

commit 24950a876c4482da59b9477317341f41a4a49dfc
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Sep 15 11:44:07 2020 +0200

    common/origin_save: Improve test for finding a visit date
    
    When trying to associate a visit date to an origin save request, only consider
    visits with partial or full statuses as no snapshots will be present for other
    ones (e.g. created, ongoing).

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/365/ for more details.

Harbormaster completed remote builds in B15129: Diff 13905.Sep 15 2020, 1:45 PM

ardumont accepted this revision.Sep 15 2020, 5:43 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.