in tests that need to read in the storage.
Using mocks just makes it more complicated, and we decided not to do that
a while ago.
Depends on D3927.
Differential D3935
migrate_extrinsic_metadata.test_debian: use the in-memory storage instead of mocks vlorentz on Sep 14 2020, 10:52 AM. Authored by
Details
in tests that need to read in the storage. Using mocks just makes it more complicated, and we decided not to do that Depends on D3927.
Diff Detail
Event TimelineComment Actions Build is green Patch application report for D3935 (id=13868)Could not rebase; Attempt merge onto ed55e9c775... Updating ed55e9c7..f6943400 Fast-forward swh/storage/migrate_extrinsic_metadata.py | 102 ++++++- .../migrate_extrinsic_metadata/test_debian.py | 308 ++++++++++++++++++++- 2 files changed, 392 insertions(+), 18 deletions(-) Changes applied before testcommit f6943400ff48ba840ab604747252ad4197fab5d9 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Mon Sep 14 10:51:48 2020 +0200 migrate_extrinsic_metadata.test_debian: use the in-memory storage instead of mocks in tests that need to read in the storage. Using mocks just makes it more complicated, and we decided not to do that a while ago. commit 7a0467972fcd0c05ff16d806b18261aba8624288 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Sep 11 14:16:21 2020 +0200 migrate_extrinsic_metadata: fix crash on dangling branch. commit 7969d368966c43ebfd51b2901c827217b0712dd5 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Sep 11 13:59:55 2020 +0200 migrate_extrinsic_metadata: fix crash when a Debian revision is missing. https://forge.softwareheritage.org/T997 commit 265fc387f7b3d5f1a55d136b74fa2ee9b9f11f58 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Sep 10 14:23:12 2020 +0200 migrate_extrinsic_metadata: guess Debian origins. This works by guessing the package name from the original_artifact data, then building origins that would match the package name, then filtering out origins by checking if the revision can be reached from them. See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/930/ for more details.
Comment Actions Build is green Patch application report for D3935 (id=13972)Rebasing onto f008a597fd... First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-942-D3935. Changes applied before testSee https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/942/ for more details. |