Page MenuHomeSoftware Heritage

migrate_extrinsic_metadata: fix crash on dangling branch.
ClosedPublic

Authored by vlorentz on Fri, Sep 11, 2:16 PM.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Fri, Sep 11, 2:16 PM

Build has FAILED

Patch application report for D3927 (id=13837)

Could not rebase; Attempt merge onto fd6d72f98e...

Merge made by the 'recursive' strategy.
 swh/storage/migrate_extrinsic_metadata.py          | 102 +++++-
 .../migrate_extrinsic_metadata/test_debian.py      | 347 ++++++++++++++++++++-
 2 files changed, 431 insertions(+), 18 deletions(-)
Changes applied before test
commit 50d75f0da9166915cc21afe45a5e0d333117ee69
Merge: fd6d72f9 af9e58de
Author: Jenkins user <jenkins@localhost>
Date:   Fri Sep 11 12:16:57 2020 +0000

    Merge branch 'diff-target' into HEAD

commit af9e58de483fcdca3e68c80351e34ad8dc5afc69
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 11 14:16:21 2020 +0200

    migrate_extrinsic_metadata: fix crash on dangling branch.

commit 236eee78d2c7d49096c5f42de07f78567c20dcea
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 11 13:59:55 2020 +0200

    migrate_extrinsic_metadata: fix crash when a Debian revision is missing.
    
    https://forge.softwareheritage.org/T997

commit e387a39752a73b057c7e019765e7a17d98497871
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 10 14:23:12 2020 +0200

    migrate_extrinsic_metadata: guess Debian origins.
    
    This works by guessing the package name from the original_artifact data,
    then building origins that would match the package name, then filtering
    out origins by checking if the revision can be reached from them.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/925/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/925/console

Build is green

Patch application report for D3927 (id=13865)

Could not rebase; Attempt merge onto ed55e9c775...

Updating ed55e9c7..7a046797
Fast-forward
 swh/storage/migrate_extrinsic_metadata.py          | 102 +++++-
 .../migrate_extrinsic_metadata/test_debian.py      | 349 ++++++++++++++++++++-
 2 files changed, 433 insertions(+), 18 deletions(-)
Changes applied before test
commit 7a0467972fcd0c05ff16d806b18261aba8624288
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 11 14:16:21 2020 +0200

    migrate_extrinsic_metadata: fix crash on dangling branch.

commit 7969d368966c43ebfd51b2901c827217b0712dd5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 11 13:59:55 2020 +0200

    migrate_extrinsic_metadata: fix crash when a Debian revision is missing.
    
    https://forge.softwareheritage.org/T997

commit 265fc387f7b3d5f1a55d136b74fa2ee9b9f11f58
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 10 14:23:12 2020 +0200

    migrate_extrinsic_metadata: guess Debian origins.
    
    This works by guessing the package name from the original_artifact data,
    then building origins that would match the package name, then filtering
    out origins by checking if the revision can be reached from them.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/929/ for more details.

ardumont accepted this revision.Mon, Sep 14, 12:04 PM
ardumont added a subscriber: ardumont.

lgtm

This revision is now accepted and ready to land.Mon, Sep 14, 12:04 PM
This revision was landed with ongoing or failed builds.Wed, Sep 16, 5:02 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D3927 (id=13971)

Rebasing onto f008a597fd...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-941-D3927.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/941/ for more details.