Differential D3923

cli: speedup the `swh` cli command startup time
ClosedPublic
Actions

Authored by douardda on Sep 10 2020, 4:30 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2575: Investigate if/how we could improve `swh` cli command startup time

Commits

rDWCLIade9e0cf6e38: cli: speedup the `swh` cli command startup time
rDWCLIab96dae9f035: Remove WebAPIClient from the swh.web.client namespace

Summary

by moving import statements in functions.

Also remove WebAPIClient from the swh.web.client namespace
so loading the cli sunmodule does not trigger the loading of
230+ modules.

Related to T2575.

Diff Detail

Repository

rDWCLI Web client

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Sep 10 2020, 4:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 10 2020, 4:30 PM

Build has FAILED

Patch application report for D3923 (id=13783)

Rebasing onto f3d89ebc4e...

Current branch diff-target is up to date.

Changes applied before test

commit 55e942ce159b175014cf5ad2e086ab186339bb7d
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 10:30:39 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions.
    
    Related to T2575.

commit 572e8769857fae532ec2d052abdc18ac0d6afb9b
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 15:04:12 2020 +0200

    Remove WebAPIClient from the swh.web.client namespace
    
    so loading the cli sunmodule does not trigger the loading of
    230+ modules.
    
    Related to T2575.

Link to build: https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/14/
See console output for more information: https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/14/console

Harbormaster failed remote builds in B15010: Diff 13783!Sep 10 2020, 4:31 PM

Also update the doc

Build has FAILED

Patch application report for D3923 (id=13785)

Rebasing onto f3d89ebc4e...

Current branch diff-target is up to date.

Changes applied before test

commit 0bc74c28c028d90f09b0349106fcfb151e566f98
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 10:30:39 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions.
    
    Related to T2575.

commit ab96dae9f035f8728802352af53373222384e0eb
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 15:04:12 2020 +0200

    Remove WebAPIClient from the swh.web.client namespace
    
    so loading the cli sunmodule does not trigger the loading of
    230+ modules.
    
    Related to T2575.

Link to build: https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/15/
See console output for more information: https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/15/console

Harbormaster failed remote builds in B15011: Diff 13785!Sep 10 2020, 4:43 PM

vlorentz accepted this revision.Sep 10 2020, 4:46 PM

This revision is now accepted and ready to land.Sep 10 2020, 4:46 PM

fix test_cli

mocking was broken

Build is green

Patch application report for D3923 (id=13787)

Rebasing onto f3d89ebc4e...

Current branch diff-target is up to date.

Changes applied before test

commit ade9e0cf6e38738408b2d8ae43de6e3089efcb01
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 10:30:39 2020 +0200

    cli: speedup the `swh` cli command startup time
    
    by moving import statements in functions.
    
    Related to T2575.

commit ab96dae9f035f8728802352af53373222384e0eb
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 15:04:12 2020 +0200

    Remove WebAPIClient from the swh.web.client namespace
    
    so loading the cli sunmodule does not trigger the loading of
    230+ modules.
    
    Related to T2575.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/16/ for more details.

Harbormaster completed remote builds in B15013: Diff 13787.Sep 10 2020, 4:58 PM

Closed by commit rDWCLIab96dae9f035: Remove WebAPIClient from the swh.web.client namespace (authored by douardda). · Explain WhySep 10 2020, 5:11 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDWCLIab96dae9f035: Remove WebAPIClient from the swh.web.client namespace.

douardda added a commit: rDWCLIade9e0cf6e38: cli: speedup the `swh` cli command startup time.