Differential D3893

spec-meta-deposit: only allow depositing metadata on one object at a time.
ClosedPublic
Actions

Authored by vlorentz on Sep 8 2020, 3:22 PM.

Details

Reviewers

moranegg

Group Reviewers

Reviewers

Commits

rDDEP70934cd578df: spec-meta-deposit: only allow depositing metadata on one object at a time.

Summary

Depositing on multiple objects at the same time may have
tricky semantics, and I don't see a use case right now.

But we can allow later by simply using multiple tags in
the <swh:reference> tree.

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Sep 8 2020, 3:22 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 8 2020, 3:22 PM

Build is green

Patch application report for D3893 (id=13730)

Could not rebase; Attempt merge onto 7c5c84b595...

Merge made by the 'recursive' strategy.
 docs/specs/spec-meta-deposit.rst | 94 +++++++++++++++++++++-------------------
 1 file changed, 49 insertions(+), 45 deletions(-)

Changes applied before test

commit fa23d13e318961d404a2ce96e2113a5d91bc1836
Merge: 7c5c84b5 70a1746a
Author: Jenkins user <jenkins@localhost>
Date:   Tue Sep 8 13:24:56 2020 +0000

    Merge branch 'diff-target' into HEAD

commit 70a1746a2a6de13ab23a7219e407ebac13118a38
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 8 15:22:09 2020 +0200

    spec-meta-deposit: only allow depositing metadata on one object at a time.
    
    Depositing on multiple objects at the same time may have
    tricky semantics, and I don't see a use case right now.
    
    But we can allow later by simply using multiple tags in
    the <swh:reference> tree.

commit 0b5b85504af05ae5ea3eb4184b078d4ec299d95a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 8 15:19:45 2020 +0200

    spec-meta-deposit: clarify wording and examples.

commit 76c5256526f1706dd57e7f55573b2eb484e80767
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 8 15:13:56 2020 +0200

    spec-meta-deposit: fix XML indent

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/59/ for more details.

Harbormaster completed remote builds in B14958: Diff 13730.Sep 8 2020, 3:27 PM

moranegg accepted this revision.Sep 8 2020, 4:08 PM

This revision is now accepted and ready to land.Sep 8 2020, 4:08 PM

rebase

Build is green

Patch application report for D3893 (id=13818)

Could not rebase; Attempt merge onto de0ab7f6f2...

Updating de0ab7f6..70934cd5
Fast-forward
 docs/specs/spec-meta-deposit.rst | 94 +++++++++++++++++++++-------------------
 1 file changed, 49 insertions(+), 45 deletions(-)

Changes applied before test

commit 70934cd578dfad0096b196358f2c7ac8b1d714b6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 8 15:22:09 2020 +0200

    spec-meta-deposit: only allow depositing metadata on one object at a time.
    
    Depositing on multiple objects at the same time may have
    tricky semantics, and I don't see a use case right now.
    
    But we can allow later by simply using multiple tags in
    the <swh:reference> tree.

commit d76fceef776e8f5a2969f1f7d285431f859fd837
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 8 15:19:45 2020 +0200

    spec-meta-deposit: clarify wording and examples.

commit 88381e36c75d0ff45f6a4dab49f21186d6e23003
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 8 15:13:56 2020 +0200

    spec-meta-deposit: fix XML indent

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/65/ for more details.

Harbormaster completed remote builds in B15043: Diff 13818.Sep 11 2020, 10:34 AM

Closed by commit rDDEP70934cd578df: spec-meta-deposit: only allow depositing metadata on one object at a time. (authored by vlorentz). · Explain WhySep 11 2020, 10:35 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDEP70934cd578df: spec-meta-deposit: only allow depositing metadata on one object at a time..