Differential D3870

Adapt storage.revision_get calls according to latest api change
ClosedPublic
Actions

Authored by ardumont on Sep 3 2020, 1:26 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T645: Type swh-storage endpoints with swh.model objects

Commits

rDLDSVN34565424f521: Adapt storage.revision_get calls according to latest api change

Summary

Related to T645

Test Plan

tox
(failing until release storage > 0.13.3 and loader.core > 0.9.1

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 3 2020, 1:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 3 2020, 1:26 PM

ardumont mentioned this in D3863: Refactor revision_get storage API to return Revision objects.Sep 3 2020, 1:26 PM

Build has FAILED

Patch application report for D3870 (id=13662)

Rebasing onto 0974947df1...

Current branch diff-target is up to date.

Changes applied before test

commit 34565424f52185204f871d82ce62da36a3a8022f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Sep 3 13:26:48 2020 +0200

    Adapt storage.revision_get calls according to latest api change
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/90/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/90/console

Harbormaster failed remote builds in B14895: Diff 13662!Sep 3 2020, 1:27 PM

vlorentz accepted this revision.Sep 3 2020, 1:54 PM

This revision is now accepted and ready to land.Sep 3 2020, 1:54 PM

Build has FAILED

Patch application report for D3870 (id=13662)

Rebasing onto 0974947df1...

Current branch diff-target is up to date.

Changes applied before test

commit 34565424f52185204f871d82ce62da36a3a8022f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Sep 3 13:26:48 2020 +0200

    Adapt storage.revision_get calls according to latest api change
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/91/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/91/console

Build is green

Patch application report for D3870 (id=13662)

Rebasing onto 0974947df1...

Current branch diff-target is up to date.

Changes applied before test

commit 34565424f52185204f871d82ce62da36a3a8022f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Sep 3 13:26:48 2020 +0200

    Adapt storage.revision_get calls according to latest api change
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/92/ for more details.

Harbormaster completed remote builds in B14895: Diff 13662.Sep 4 2020, 1:35 PM

Closed by commit rDLDSVN34565424f521: Adapt storage.revision_get calls according to latest api change (authored by ardumont). · Explain WhySep 4 2020, 1:43 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDSVN34565424f521: Adapt storage.revision_get calls according to latest api change.