diff --git a/swh/loader/svn/loader.py b/swh/loader/svn/loader.py --- a/swh/loader/svn/loader.py +++ b/swh/loader/svn/loader.py @@ -186,10 +186,10 @@ return None swh_id = branch.target - revs = list(storage.revision_get([swh_id])) - if not revs or revs[0] is None: + revision = storage.revision_get([swh_id])[0] + if not revision: return None - return latest_snapshot, Revision.from_dict(revs[0]) + return latest_snapshot, revision def build_swh_revision(self, rev, commit, dir_id, parents): """Build the swh revision dictionary. diff --git a/swh/loader/svn/tests/test_loader.py b/swh/loader/svn/tests/test_loader.py --- a/swh/loader/svn/tests/test_loader.py +++ b/swh/loader/svn/tests/test_loader.py @@ -112,12 +112,9 @@ assert stats["snapshot"] == 1 # even starting from previous revision... - revs = list( - loader.storage.revision_get( - [hash_to_bytes("95edacc8848369d6fb1608e887d6d2474fd5224f")] - ) - ) - start_revision = revs[0] + start_revision = loader.storage.revision_get( + [hash_to_bytes("95edacc8848369d6fb1608e887d6d2474fd5224f")] + )[0] assert start_revision is not None loader = SvnLoader(repo_url, swh_revision=start_revision) @@ -284,12 +281,9 @@ snapshot=GOURMET_SNAPSHOT.id, ) - revs = list( - loader.storage.revision_get( - [hash_to_bytes("95edacc8848369d6fb1608e887d6d2474fd5224f")] - ) - ) - start_revision = revs[0] + start_revision = loader.storage.revision_get( + [hash_to_bytes("95edacc8848369d6fb1608e887d6d2474fd5224f")] + )[0] assert start_revision is not None archive_path = os.path.join(datadir, "pkg-gourmet-with-updates.tgz")