Differential D3830

assets/save: encode iso8601 date in URI component
ClosedPublic
Actions

Authored by anlambert on Aug 24 2020, 1:51 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2532: Broken links in Save Code Now browse request pages

Commits

rDWAPPSf513a56b554f: assets/save: encode iso8601 date in URI component

Summary

ISO 8601 dates contain characters (+ for instance) that need to be percent
encoded when using them as URI components.

Closes T2532

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Aug 24 2020, 1:51 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 24 2020, 1:51 PM

Build is green

Patch application report for D3830 (id=13481)

Rebasing onto 37a8f590ad...

Current branch diff-target is up to date.

Changes applied before test

commit f513a56b554f13a6e00b53f863739a0b36bc3f1b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Aug 24 13:49:23 2020 +0200

    assets/save: encode iso8601 date in URI component
    
    ISO 8601 dates contain characters (+ for instance) that need to be percent
    encoded when using them as URI components.
    
    Closes T2532

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/341/ for more details.

Harbormaster completed remote builds in B14741: Diff 13481.Aug 24 2020, 1:58 PM

ardumont accepted this revision.Aug 24 2020, 2:01 PM

This revision is now accepted and ready to land.Aug 24 2020, 2:01 PM

Closed by commit rDWAPPSf513a56b554f: assets/save: encode iso8601 date in URI component (authored by anlambert). · Explain WhyAug 24 2020, 2:08 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSf513a56b554f: assets/save: encode iso8601 date in URI component.