Differential D3816

tests: remove invalid assertion
ClosedPublic
Actions

Authored by vlorentz on Aug 20 2020, 12:46 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDCIDX66bbfdf29664: tests: remove invalid assertion

Summary

It assumed contents are paginated by their sha1, which is
an implementation detail of the storage (and isn't true for the
cassandra storage, or for the new in-mem).

And it's irrelevant anyway, as it only serves to test the consistency
of swh-storage, not swh-indexer.

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 20 2020, 12:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 20 2020, 12:46 PM

Build is green

Patch application report for D3816 (id=13431)

Rebasing onto b717a504a8...

Current branch diff-target is up to date.

Changes applied before test

commit 66bbfdf29664e7c5b5afcff16e007302286f0dff
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 20 12:45:32 2020 +0200

    tests: remove invalid assertion
    
    It assumed contents are paginated by their sha1, which is
    an implementation detail of the storage (and isn't true for the
    cassandra storage, or for the new in-mem).
    
    And it's irrelevant anyway, as it only serves to test the consistency
    of swh-storage, not swh-indexer.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/45/ for more details.

Harbormaster completed remote builds in B14695: Diff 13431.Aug 20 2020, 12:47 PM

douardda accepted this revision.Aug 20 2020, 12:55 PM

This revision is now accepted and ready to land.Aug 20 2020, 12:55 PM

Closed by commit rDCIDX66bbfdf29664: tests: remove invalid assertion (authored by vlorentz). · Explain WhyAug 20 2020, 12:59 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDX66bbfdf29664: tests: remove invalid assertion.