Differential D3813

templates/homepage: Hide counters and graphs when data are missing
ClosedPublic
Actions

Authored by anlambert on Aug 20 2020, 12:05 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS4332763d1cf1: templates/homepage: Hide counters and graphs when data are missing

Summary

Some storage backends do not provide the same set of counters as the pgsql one.
For instance, cassandra based backend does not offer the person counter.

So handle those cases in the webapp homepage by hiding counters and graphs
whose input data are missing.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Aug 20 2020, 12:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 20 2020, 12:05 PM

Build has FAILED

Patch application report for D3813 (id=13427)

Rebasing onto 652b39bd1d...

Current branch diff-target is up to date.

Changes applied before test

commit 4332763d1cf13e0d10ce331fd8caf171e5d8901c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Aug 19 17:53:17 2020 +0200

    templates/homepage: Hide counters and graphs when data are missing
    
    Some storage backends do not provide the same set of counters as the pgsql one.
    For instance, cassandra based backend does not offer the person counter.
    
    So handle those cases in the webapp homepage by hiding counters and graphs
    whose input data are missing.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/333/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/333/console

Harbormaster failed remote builds in B14691: Diff 13427!Aug 20 2020, 12:08 PM

vlorentz accepted this revision.Aug 20 2020, 12:48 PM

This revision is now accepted and ready to land.Aug 20 2020, 12:48 PM

Build is green

Patch application report for D3813 (id=13427)

Rebasing onto 652b39bd1d...

Current branch diff-target is up to date.

Changes applied before test

commit 4332763d1cf13e0d10ce331fd8caf171e5d8901c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Aug 19 17:53:17 2020 +0200

    templates/homepage: Hide counters and graphs when data are missing
    
    Some storage backends do not provide the same set of counters as the pgsql one.
    For instance, cassandra based backend does not offer the person counter.
    
    So handle those cases in the webapp homepage by hiding counters and graphs
    whose input data are missing.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/334/ for more details.

Harbormaster completed remote builds in B14691: Diff 13427.Aug 20 2020, 1:10 PM

Closed by commit rDWAPPS4332763d1cf1: templates/homepage: Hide counters and graphs when data are missing (authored by anlambert). · Explain WhyAug 20 2020, 1:11 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS4332763d1cf1: templates/homepage: Hide counters and graphs when data are missing.