Differential D3812

package loader: Add the 'url' to the original_artifact extrinsic metadata.
ClosedPublic
Actions

Authored by vlorentz on Aug 20 2020, 11:07 AM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDLDBASE3bbd95f8f407: package loader: Add the 'url' to the 'original_artifact' extrinsic metadata.

Summary

The Debian loader currently does in the 'extrinsic' revision metadata;
so this avoids losing the URL when we stop writing extrinsic metadata
on revision objects.

Additionally, this makes all loaders write the 'url', which can be
useful later.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 20 2020, 11:07 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 20 2020, 11:07 AM

Build is green

Patch application report for D3812 (id=13426)

Rebasing onto b0a6dfcbc3...

Current branch diff-target is up to date.

Changes applied before test

commit 853fe381b75d19b11c130830b0a69f33121f7813
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 20 11:06:56 2020 +0200

    package loader: Add the 'url' to the original_artifact extrinsic metadata.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/287/ for more details.

Harbormaster completed remote builds in B14690: Diff 13426.Aug 20 2020, 11:09 AM

ok but please explain why in your commit message...

This revision is now accepted and ready to land.Aug 20 2020, 12:56 PM

vlorentz edited the summary of this revision. (Show Details)Aug 20 2020, 1:02 PM

add commit description

Build is green

Patch application report for D3812 (id=13435)

Rebasing onto b0a6dfcbc3...

Current branch diff-target is up to date.

Changes applied before test

commit 3bbd95f8f40716f0937ad356a1789350cd0d3dc0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 20 11:06:56 2020 +0200

    package loader: Add the 'url' to the 'original_artifact' extrinsic metadata.
    
    The Debian loader currently does in the 'extrinsic' revision metadata;
    so this avoids losing the URL when we stop writing extrinsic metadata
    on revision objects.
    
    Additionally, this makes all loaders write the 'url', which can be
    useful later.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/288/ for more details.

Harbormaster completed remote builds in B14699: Diff 13435.Aug 20 2020, 1:04 PM

Closed by commit rDLDBASE3bbd95f8f407: package loader: Add the 'url' to the 'original_artifact' extrinsic metadata. (authored by vlorentz). · Explain WhyAug 20 2020, 1:12 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBASE3bbd95f8f407: package loader: Add the 'url' to the 'original_artifact' extrinsic metadata..