Differential D3730

vault.to_disk: Rename content_get call to content_get_data
ClosedPublic
Actions

Authored by ardumont on Aug 6 2020, 11:28 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDVAU239df3352015: vault.to_disk: Rename content_get call to content_get_data

Summary

This also adds types and simplify the existing code.

Test Plan

tox
(failing until storage release > 0.12)

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Aug 6 2020, 11:28 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 6 2020, 11:28 PM

Build has FAILED

Patch application report for D3730 (id=13134)

Rebasing onto 1c0ae80d8e...

Current branch diff-target is up to date.

Changes applied before test

commit 2618d5b728a91617ff50b017c10fc86df857854f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:28:46 2020 +0200

    vault.to_disk: Simplify and type existing code

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/9/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/9/console

Harbormaster failed remote builds in B14400: Diff 13134!Aug 6 2020, 11:29 PM

Cannot separate the diff in the end, the simplification goes with the api change.

ardumont edited the test plan for this revision. (Show Details)Aug 6 2020, 11:32 PM

Build has FAILED

Patch application report for D3730 (id=13136)

Rebasing onto 1c0ae80d8e...

Current branch diff-target is up to date.

Changes applied before test

commit 239df335201599efbf65dfe9dd332294e3ad836e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:28:46 2020 +0200

    vault.to_disk: Rename content_get call to content_get_data
    
    This also adds type and simplify the existing code

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/11/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/11/console

Harbormaster failed remote builds in B14402: Diff 13136!Aug 6 2020, 11:32 PM

ardumont retitled this revision from vault.to_disk: Simplify and type existing code to vault.to_disk: Rename content_get call to content_get_data.Aug 6 2020, 11:32 PM

ardumont edited the summary of this revision. (Show Details)

ardumont mentioned this in D3728: storage*: Rename and type content_get_data(Sha1) -> Optional[bytes].Aug 7 2020, 12:44 AM

vlorentz accepted this revision.Aug 7 2020, 9:26 AM

This revision is now accepted and ready to land.Aug 7 2020, 9:26 AM

Build is green

Patch application report for D3730 (id=13136)

Rebasing onto 1c0ae80d8e...

Current branch diff-target is up to date.

Changes applied before test

commit 239df335201599efbf65dfe9dd332294e3ad836e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:28:46 2020 +0200

    vault.to_disk: Rename content_get call to content_get_data
    
    This also adds type and simplify the existing code

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/12/ for more details.

Harbormaster completed remote builds in B14402: Diff 13136.Aug 7 2020, 2:50 PM

Closed by commit rDVAU239df3352015: vault.to_disk: Rename content_get call to content_get_data (authored by ardumont). · Explain WhyAug 7 2020, 2:55 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDVAU239df3352015: vault.to_disk: Rename content_get call to content_get_data.