Page MenuHomeSoftware Heritage

vault.to_disk: Rename content_get call to content_get_data
ClosedPublic

Authored by ardumont on Aug 6 2020, 11:28 PM.

Details

Summary

This also adds types and simplify the existing code.

Test Plan

tox
(failing until storage release > 0.12)

Diff Detail

Repository
rDVAU Software Heritage Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D3730 (id=13134)

Rebasing onto 1c0ae80d8e...

Current branch diff-target is up to date.
Changes applied before test
commit 2618d5b728a91617ff50b017c10fc86df857854f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:28:46 2020 +0200

    vault.to_disk: Simplify and type existing code

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/9/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/9/console

Cannot separate the diff in the end, the simplification goes with the api change.

Build has FAILED

Patch application report for D3730 (id=13136)

Rebasing onto 1c0ae80d8e...

Current branch diff-target is up to date.
Changes applied before test
commit 239df335201599efbf65dfe9dd332294e3ad836e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:28:46 2020 +0200

    vault.to_disk: Rename content_get call to content_get_data
    
    This also adds type and simplify the existing code

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/11/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/11/console

ardumont retitled this revision from vault.to_disk: Simplify and type existing code to vault.to_disk: Rename content_get call to content_get_data.Aug 6 2020, 11:32 PM
ardumont edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Aug 7 2020, 9:26 AM

Build is green

Patch application report for D3730 (id=13136)

Rebasing onto 1c0ae80d8e...

Current branch diff-target is up to date.
Changes applied before test
commit 239df335201599efbf65dfe9dd332294e3ad836e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:28:46 2020 +0200

    vault.to_disk: Rename content_get call to content_get_data
    
    This also adds type and simplify the existing code

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/12/ for more details.