Page MenuHomeSoftware Heritage
Differential D371

swh.lister.gitlab: Make rate limit check optional
ClosedPublic
Actions

Authored by ardumont on Jul 6 2018, 4:19 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Summary

Samples of gitlab instance not implementing it (yet?):

Related T989

Diff Detail

Repository
rDLS Listers
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1295
Build 1639: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 6 2018, 4:19 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 6 2018, 4:19 PM
Harbormaster completed remote builds in B1295: Diff 1154.Jul 6 2018, 4:19 PM
olasd accepted this revision.Jul 6 2018, 7:20 PM
olasd added a subscriber: olasd.

I was confused for a moment, but I just think your list is a bit too complete: gitlab.com has rate limiting headers ;)

This revision is now accepted and ready to land.Jul 6 2018, 7:20 PM
ardumont edited the summary of this revision. (Show Details)Jul 6 2018, 8:05 PM

I was confused for a moment, but I just think your list is a bit too complete: gitlab.com has rate limiting headers ;)

Right, i forgot to remove gitlab.com from the list!

ardumont added a comment.Jul 11 2018, 10:19 AM

I amended the commit message as well (which the comments came from ;)

ardumont closed this revision.Jul 17 2018, 6:13 PM
ardumont added a comment.Jul 17 2018, 6:30 PM

Related rDLS3ca566776fe2d67ab2c21f35937e6c77c793f022

Revision Contents
Changeset List

PathSize
swh/
lister/
gitlab/
14 lines

Diff 1154

View Options

swh/lister/gitlab/lister.py

Loading...
About · Developer information · Legal