Differential D3687

storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> Sha1Git
ClosedPublic
Actions

Authored by ardumont on Aug 3 2020, 1:27 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T645: Type swh-storage endpoints with swh.model objects

Commits

rDSTO3c2e5a3d7d43: storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> Sha1Git

Summary

Basic but consistent across those "dag" object endpoints.

Related to T645

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14234
Build 21883: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21882: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 3 2020, 1:27 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 3 2020, 1:27 PM

Build has FAILED

Patch application report for D3687 (id=12992)

Rebasing onto aa58e1092f...

Current branch diff-target is up to date.

Changes applied before test

commit 0d5b2552ab6c5c0dc2ae966130d900404ddd1005
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Aug 3 13:21:29 2020 +0200

    storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> bytes
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/654/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/654/console

Harbormaster failed remote builds in B14233: Diff 12992!Aug 3 2020, 1:31 PM

Drop unneeded checks which fails the build (the directory-add already tells it
added something).

This aligns directory-get-random with other endpoints, *get-random should
return something.

Build is green

Patch application report for D3687 (id=12993)

Rebasing onto aa58e1092f...

Current branch diff-target is up to date.

Changes applied before test

commit ad8c4c1132cab53607897544bdf7188414a5f7fa
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Aug 3 13:21:29 2020 +0200

    storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> bytes
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/655/ for more details.

Harbormaster completed remote builds in B14234: Diff 12993.Aug 3 2020, 1:44 PM

Could you return Sha1Git instead? (It's an alias of bytes for now, so it doesn't matter that much)

Could you return Sha1Git instead? (It's an alias of bytes for now, so it doesn't matter that much)

yes!

(I forgot i wanted to check!)

Fix signature to use Sha1Git

ardumont retitled this revision from storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> bytes to storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> Sha1Git.Aug 3 2020, 4:23 PM

Build is green

Patch application report for D3687 (id=12995)

Rebasing onto aa58e1092f...

Current branch diff-target is up to date.

Changes applied before test

commit 3c2e5a3d7d4332bf79afd40c2e0022d6eccc62be
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Aug 3 13:21:29 2020 +0200

    storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> Sha1Git
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/656/ for more details.

Harbormaster completed remote builds in B14236: Diff 12995.Aug 3 2020, 4:27 PM

vlorentz accepted this revision.Aug 3 2020, 5:58 PM

This revision is now accepted and ready to land.Aug 3 2020, 5:58 PM

Closed by commit rDSTO3c2e5a3d7d43: storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> Sha1Git (authored by ardumont). · Explain WhyAug 3 2020, 6:06 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO3c2e5a3d7d43: storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> Sha1Git.