Page MenuHomeSoftware Heritage

storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> Sha1Git
ClosedPublic

Authored by ardumont on Aug 3 2020, 1:27 PM.

Details

Summary

Basic but consistent across those "dag" object endpoints.

Related to T645

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Aug 3 2020, 1:27 PM

Build has FAILED

Patch application report for D3687 (id=12992)

Rebasing onto aa58e1092f...

Current branch diff-target is up to date.
Changes applied before test
commit 0d5b2552ab6c5c0dc2ae966130d900404ddd1005
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Aug 3 13:21:29 2020 +0200

    storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> bytes
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/654/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/654/console

ardumont updated this revision to Diff 12993.Aug 3 2020, 1:40 PM

Drop unneeded checks which fails the build (the directory-add already tells it
added something).

This aligns directory-get-random with other endpoints, *get-random should
return something.

Build is green

Patch application report for D3687 (id=12993)

Rebasing onto aa58e1092f...

Current branch diff-target is up to date.
Changes applied before test
commit ad8c4c1132cab53607897544bdf7188414a5f7fa
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Aug 3 13:21:29 2020 +0200

    storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> bytes
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/655/ for more details.

Could you return Sha1Git instead? (It's an alias of bytes for now, so it doesn't matter that much)

Could you return Sha1Git instead? (It's an alias of bytes for now, so it doesn't matter that much)

yes!

(I forgot i wanted to check!)

ardumont updated this revision to Diff 12995.Aug 3 2020, 4:23 PM

Fix signature to use Sha1Git

ardumont retitled this revision from storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> bytes to storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> Sha1Git.Aug 3 2020, 4:23 PM

Build is green

Patch application report for D3687 (id=12995)

Rebasing onto aa58e1092f...

Current branch diff-target is up to date.
Changes applied before test
commit 3c2e5a3d7d4332bf79afd40c2e0022d6eccc62be
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Aug 3 13:21:29 2020 +0200

    storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> Sha1Git
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/656/ for more details.

vlorentz accepted this revision.Aug 3 2020, 5:58 PM
This revision is now accepted and ready to land.Aug 3 2020, 5:58 PM