Page MenuHomeSoftware Heritage

indexer.rehash: Fix type
ClosedPublic

Authored by ardumont on Fri, Jul 31, 2:40 PM.

Details

Summary

This fixes build [1]

This fails thanks to D3635 which revealed that the type is no longer correct in
that code!

This code is:

  • not covered
  • no longer used

I'm just making it type so the build gets back to its feet.

It got used once to update our contents with the new blake2s256 column.

Wondering whether or drop it (we could drop the storage.content_update
as well as it is the only client). I gather if we need something similar in the future,
we could use a tested journal implementation instead (it worked ok at the times heh)

[1] https://jenkins.softwareheritage.org/job/DCIDX/job/tests/1075/console

Test Plan

tox

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Fri, Jul 31, 2:40 PM
ardumont edited the summary of this revision. (Show Details)Fri, Jul 31, 2:41 PM

Build is green

Patch application report for D3670 (id=12916)

Rebasing onto d5965060d1...

Current branch diff-target is up to date.
Changes applied before test
commit 62d73ed83d17fcaf75684d370de586514a68b963
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 31 14:37:58 2020 +0200

    indexer.rehash: Fix type
    
    This fixes build [1]
    
    [1] https://jenkins.softwareheritage.org/job/DCIDX/job/tests/1075/console

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/29/ for more details.

ardumont edited the summary of this revision. (Show Details)Fri, Jul 31, 2:44 PM
vlorentz accepted this revision.Fri, Jul 31, 3:15 PM
This revision is now accepted and ready to land.Fri, Jul 31, 3:15 PM
This revision was automatically updated to reflect the committed changes.