Page MenuHomeSoftware Heritage

Make @remote_api_endpoint preserve typing information for mypy.
ClosedPublic

Authored by vlorentz on Wed, Jul 29, 9:57 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Summary

Before this commit, decorating with @remote_api_endpoint made
mypy completely unable to detect the type of the decorated function.

Diff Detail

Event Timeline

vlorentz created this revision.Wed, Jul 29, 9:57 AM

Build is green

Patch application report for D3635 (id=12794)

Rebasing onto 028ef739da...

Current branch diff-target is up to date.
Changes applied before test
commit 6b3f238e1f5398ea03e7213cb373b9ada40c9cc5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 29 09:57:13 2020 +0200

    Make @remote_api_endpoint preserve typing information for mypy.
    
    Before this commit, decorating with @remote_api_endpoint made
    mypy completely unable to detect the type of the decorated function.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/31/ for more details.

ardumont accepted this revision.Wed, Jul 29, 10:48 AM
This revision is now accepted and ready to land.Wed, Jul 29, 10:48 AM
ardumont added a comment.EditedWed, Jul 29, 2:15 PM

Rebase, push and tag so we can rebuild D3637 and D3636?

No, this diff only breaks stuff, the other diffs don't need it.