Make @remote_api_endpoint preserve typing information for mypy.
ClosedPublic
Actions

Authored by vlorentz on Jul 29 2020, 9:57 AM.

Details

Reviewers

Group Reviewers

Summary

Before this commit, decorating with @remote_api_endpoint made
mypy completely unable to detect the type of the decorated function.

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14024
Build 21526: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21525: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 29 2020, 9:57 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 29 2020, 9:57 AM

Build is green

Patch application report for D3635 (id=12794)

Rebasing onto 028ef739da...

Current branch diff-target is up to date.

Changes applied before test

commit 6b3f238e1f5398ea03e7213cb373b9ada40c9cc5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 29 09:57:13 2020 +0200

    Make @remote_api_endpoint preserve typing information for mypy.
    
    Before this commit, decorating with @remote_api_endpoint made
    mypy completely unable to detect the type of the decorated function.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/31/ for more details.

Harbormaster completed remote builds in B14024: Diff 12794.Jul 29 2020, 9:59 AM

ardumont accepted this revision.Jul 29 2020, 10:48 AM

This revision is now accepted and ready to land.Jul 29 2020, 10:48 AM

Rebase, push and tag so we can rebuild D3637 and D3636?