Unbreaks swh-loader-core's tests, which are all red when run with the current
swh-storage version.
Unfortunately, swh-storage's tests did not catch it, because the in-memory
backend works fine with iterables, but the pg backend doesn't.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDSTOe63b78c6f9b2: buffer: Pass lists to backend functions, not iterables.
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14081 Build 21624: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 21623: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D3649 (id=12845)
Rebasing onto 7667f7eef9...
Current branch diff-target is up to date.
Changes applied before test
commit e63b78c6f9b2a23599f1bbc791d0e039aa3e2864
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jul 30 11:30:28 2020 +0200
buffer: Pass lists to backend functions, not iterables.
Unbreaks swh-loader-core's tests, which are all red when run with the current
swh-storage version.
Unfortunately, swh-storage's tests did not catch it, because the in-memory
backend works fine with iterables, but the pg backend doesn't.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/617/ for more details.