Allows us to export subdatasets easily
Diff Detail
- Repository
- rDGRPH Compressed graph representation
- Branch
- visit_edges
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13994 Build 21475: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 21474: arc lint + arc unit
Event Timeline
Build is green
Patch application report for D3600 (id=12681)
Rebasing onto 3943007422...
Current branch diff-target is up to date.
Changes applied before test
commit d987735e40d74adfc13e6f88956f0d6be26720cb Author: Antoine Pietri <antoine.pietri1@gmail.com> Date: Thu Jul 23 13:15:08 2020 +0200 doc: add visit/edges endpoint documentation commit 1e9b322ea34dbb67dbd205283c0891790bb56e89 Author: Antoine Pietri <antoine.pietri1@gmail.com> Date: Thu Jul 23 13:05:06 2020 +0200 pid: use SWHID functions instead of deprecated PID ones commit dd9ecf6e6fc70489c882d9518b301a774188fc0f Author: Antoine Pietri <antoine.pietri1@gmail.com> Date: Thu Jul 23 11:26:15 2020 +0200 Add visit_edges endpoint
See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/11/ for more details.
java/src/main/java/org/softwareheritage/graph/algo/Traversal.java | ||
---|---|---|
170–173 | Consider the graph A→B, C→B and assume A and B are visited first. |
java/src/main/java/org/softwareheritage/graph/algo/Traversal.java | ||
---|---|---|
170–173 | You're right, I don't know how I missed that. This call should be outside the if. Nice catch, thanks. |
Build is green
Patch application report for D3600 (id=12692)
Rebasing onto 3943007422...
Current branch diff-target is up to date.
Changes applied before test
commit 7e97538b7ffa27984f633b429779fdd471880c61 Author: Antoine Pietri <antoine.pietri1@gmail.com> Date: Thu Jul 23 15:44:20 2020 +0200 visit/edges: fix incorrect handling of diamond pattern commit d987735e40d74adfc13e6f88956f0d6be26720cb Author: Antoine Pietri <antoine.pietri1@gmail.com> Date: Thu Jul 23 13:15:08 2020 +0200 doc: add visit/edges endpoint documentation commit 1e9b322ea34dbb67dbd205283c0891790bb56e89 Author: Antoine Pietri <antoine.pietri1@gmail.com> Date: Thu Jul 23 13:05:06 2020 +0200 pid: use SWHID functions instead of deprecated PID ones commit dd9ecf6e6fc70489c882d9518b301a774188fc0f Author: Antoine Pietri <antoine.pietri1@gmail.com> Date: Thu Jul 23 11:26:15 2020 +0200 Add visit_edges endpoint
See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/13/ for more details.
looks overall good to me (see my comments), not sure I'm 100% confident there are enough corner case tests (for complex multi diamond shaped graphs), but I let zack judge this.
Also, the "visit/edges: fix incorrect handling of diamond pattern" revision should be squashed in the first one of this branch.
swh/graph/client.py | ||
---|---|---|
55 | no fstring? | |
58 | is this print statement supposed to live here? | |
swh/graph/server/app.py | ||
213 | same "print" question | |
218 | same fstring question :-) |
Build is green
Patch application report for D3600 (id=12763)
Rebasing onto 3943007422...
Current branch diff-target is up to date.
Changes applied before test
commit c5802bbe595673102ff593b8fb91ea600748cd1b Author: Antoine Pietri <antoine.pietri1@gmail.com> Date: Mon Jul 27 18:12:53 2020 +0200 Remove debug prints commit 7e97538b7ffa27984f633b429779fdd471880c61 Author: Antoine Pietri <antoine.pietri1@gmail.com> Date: Thu Jul 23 15:44:20 2020 +0200 visit/edges: fix incorrect handling of diamond pattern commit d987735e40d74adfc13e6f88956f0d6be26720cb Author: Antoine Pietri <antoine.pietri1@gmail.com> Date: Thu Jul 23 13:15:08 2020 +0200 doc: add visit/edges endpoint documentation commit 1e9b322ea34dbb67dbd205283c0891790bb56e89 Author: Antoine Pietri <antoine.pietri1@gmail.com> Date: Thu Jul 23 13:05:06 2020 +0200 pid: use SWHID functions instead of deprecated PID ones commit dd9ecf6e6fc70489c882d9518b301a774188fc0f Author: Antoine Pietri <antoine.pietri1@gmail.com> Date: Thu Jul 23 11:26:15 2020 +0200 Add visit_edges endpoint
See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/14/ for more details.