Differential D3578

test_storage: Migrate last storage to use model objects
ClosedPublic
Actions

Authored by ardumont on Jul 20 2020, 10:25 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTO42ae56d98546: test_storage: Migrate last storage to use model objects

Summary

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13815
Build 21173: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21172: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 20 2020, 10:25 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 20 2020, 10:25 PM

Build is green

Patch application report for D3578 (id=12590)

Could not rebase; Attempt merge onto c9e921eb45...

Updating c9e921eb..42ae56d9
Fast-forward
 swh/storage/pytest_plugin.py            |  29 +-
 swh/storage/tests/conftest.py           |   6 +-
 swh/storage/tests/test_pytest_plugin.py |   6 +-
 swh/storage/tests/test_retry.py         |   6 +-
 swh/storage/tests/test_storage.py       | 539 ++++++++++++++++----------------
 5 files changed, 298 insertions(+), 288 deletions(-)

Changes applied before test

commit 42ae56d9854682021ca6758efbca870d96db05e7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 22:23:09 2020 +0200

    test_storage: Migrate last storage to use model objects
    
    Related to T2494

commit d4f896e00225f0e732d79549604036142b2af7b7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 22:21:56 2020 +0200

    test_storage: test_origin: Use data model object
    
    Related to T2494

commit 6bdfd85c92088813b31884771b5bed41b9d9cba8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 21:44:09 2020 +0200

    test_storage: origin_metadata: Centralize objects within sample_data_model
    
    Related to T2494

commit a6f70c368031e0f5d090fd655970447f5b6b7756
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 21:12:55 2020 +0200

    test_storage: content_metadata: Centralize objects within sample_data_model
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/511/ for more details.

Harbormaster completed remote builds in B13815: Diff 12590.Jul 20 2020, 10:51 PM

vlorentz accepted this revision.Jul 21 2020, 9:25 AM

This revision is now accepted and ready to land.Jul 21 2020, 9:25 AM

Closed by commit rDSTO42ae56d98546: test_storage: Migrate last storage to use model objects (authored by ardumont). · Explain WhyJul 21 2020, 9:36 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO42ae56d98546: test_storage: Migrate last storage to use model objects.