To work with the new swh-model version, which uses ImmutableDict in model objects.
Introducing the map_optional function just for that may seem pointless, but I use it a lot in D3456.
Details
Details
- Reviewers
vlorentz olasd - Group Reviewers
Reviewers - Commits
- rDSTO8bf3794874fa: Convert ImmutableDict to dict before passing it to json.dumps.
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- immutable-dict-json
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13512 Build 20676: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 20675: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 101,000 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.algos.test_snapshot::test_snapshot_large swh_storage = <swh.storage.validate.ValidatingProxyStorage object at 0x7f1e50220198>
@given(branch_name=branch_names(), branch_target=branch_targets(only_objects=True))
| |
| 4 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_content | |
| 2 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_origin | |
| 4 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_origin_visit | |
| 4 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_revision | |
| View Full Test Results (1 Failed · 779 Passed · 17 Skipped) |
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D3476 (id=12291)
Rebasing onto c21d0e3820...
Current branch diff-target is up to date.
Changes applied before test
commit 9df56b5d85fbb8a55877a811970e062ecdc022a4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jul 9 10:27:12 2020 +0200
Convert ImmutableDict to dict before passing it to json.dumps.
To work with the new swh-model version, which uses ImmutableDict in model objects.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/426/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/426/console
Comment Actions
Not sure I buy the map_optional here. When I read a line of code with [x if x else f(x)] I understand it right away. With map_optional, I need to go get the definition of that oneliner function.
Plus you have the type annotation headache...
Comment Actions
Build has FAILED
Patch application report for D3476 (id=12293)
Rebasing onto c21d0e3820...
Current branch diff-target is up to date.
Changes applied before test
commit e4f044f06948aa1510ed0cc99d4549211c5f0097
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jul 9 10:27:12 2020 +0200
Convert ImmutableDict to dict before passing it to json.dumps.
To work with the new swh-model version, which uses ImmutableDict in model objects.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/428/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/428/console
| swh/storage/db.py | ||
|---|---|---|
| 22–25 | I guess this would make sense "upstream" too. | |
Comment Actions
Build has FAILED
Patch application report for D3476 (id=12294)
Rebasing onto c21d0e3820...
Current branch diff-target is up to date.
Changes applied before test
commit 8bf3794874fab66a3049204d3dd391d2b66cae4b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jul 9 10:27:12 2020 +0200
Convert ImmutableDict to dict before passing it to json.dumps.
To work with the new swh-model version, which uses ImmutableDict in model objects.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/429/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/429/console
| swh/storage/db.py | ||
|---|---|---|
| 22–25 | we can't, this helper function is too loosely defined to be able to do so. Here we know we will use it on dict-like structures only. | |