If that makes sense.
Either that or we need to push down the original_artifact part into the
different package loader implementations.
Fix build [1]
[1] https://jenkins.softwareheritage.org/job/DLDBASE/job/tests/919/console
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDLDBASE6dc3da1580d9: Update the revision metadata field as an immutable dict
tox
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13496 Build 20650: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 20649: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D3471 (id=12273)
Rebasing onto 488b515a1c...
Current branch diff-target is up to date.
Changes applied before test
commit 8762b61d6a3c06058a2fc3e1b8b8279ffe79556a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Wed Jul 8 18:10:00 2020 +0200
Update the revision metadata field as an immutable dict
Fix build [1]
[1] https://jenkins.softwareheritage.org/job/DLDBASE/job/tests/919/consoleSee https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/117/ for more details.
| swh/loader/package/loader.py | ||
|---|---|---|
| 430–432 | Replace these three lines with: full_metadata = list(revision.metadata.items()) + [extra_metadata] it's shorter and spares a copy | |
| swh/loader/package/loader.py | ||
|---|---|---|
| 430–432 | +1 ;) | |
Comment Actions
Build is green
Patch application report for D3471 (id=12277)
Rebasing onto 488b515a1c...
Current branch diff-target is up to date.
Changes applied before test
commit 6dc3da1580d9d35cc9e7478f134b5246e058dc78
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Wed Jul 8 18:10:00 2020 +0200
Update the revision metadata field as an immutable dict
Fix build [1]
[1] https://jenkins.softwareheritage.org/job/DLDBASE/job/tests/919/consoleSee https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/118/ for more details.