Page MenuHomeSoftware Heritage

svn.loader: Fix uneventful visit case
ClosedPublic

Authored by ardumont on Jul 3 2020, 2:23 PM.

Details

Summary

It was unexpectedly "eventftul" so far [1]. Most probably since [2] [3] or
something near.

[1] https://forge.softwareheritage.org/D3399#inline-23571

[2] https://forge.softwareheritage.org/D2887

[3] https://forge.softwareheritage.org/D2889

Test Plan

tox

Diff Detail

Event Timeline

ardumont created this revision.Jul 3 2020, 2:23 PM

Build is green

Patch application report for D3413 (id=12096)

Could not rebase; Attempt merge onto 4cb4b0301e...

Updating 4cb4b03..ab41ee2
Fast-forward
 swh/loader/svn/loader.py                           |   1 +
 .../resources/pkg-gourmet-tampered-rev6-log.tgz    | Bin 0 -> 133120 bytes
 swh/loader/svn/tests/test_loader.py                | 206 +++++----------------
 3 files changed, 46 insertions(+), 161 deletions(-)
 create mode 100644 swh/loader/svn/tests/resources/pkg-gourmet-tampered-rev6-log.tgz
Changes applied before test
commit ab41ee2f7b324b9d9f3a39064aa0eda3e41de789
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 14:17:02 2020 +0200

    svn.loader: Fix uneventful visit case
    
    It was unexpectedly "eventftul" so far [1]. Most probably since [2] [3] or
    something near.
    
    [1] https://forge.softwareheritage.org/D3399#inline-23571
    
    [2] https://forge.softwareheritage.org/D2887
    
    [3] https://forge.softwareheritage.org/D2889

commit 978a50d2edce7b395d914b8cbb2b1e7442c806ca
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 13:59:25 2020 +0200

    tests: Drop dead code
    
    Related to T2462

commit 01f9382e7442ef6510d016b7f7f42d6ac4c04b22
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 13:52:16 2020 +0200

    tests: Refactor repository with tampered information scenario
    
    This actually uses a real modified repository.
    
    Prior to this, this faked the alteration by modifying the input of the loader
    which is a hack.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/62/ for more details.

anlambert accepted this revision.Jul 3 2020, 2:36 PM
anlambert added a subscriber: anlambert.

Tests refactoring which uncover bugs, nice !

This revision is now accepted and ready to land.Jul 3 2020, 2:36 PM

Build is green

Patch application report for D3413 (id=12099)

Could not rebase; Attempt merge onto 4cb4b0301e...

Updating 4cb4b03..393cd62
Fast-forward
 swh/loader/svn/loader.py                           |   1 +
 .../resources/pkg-gourmet-tampered-rev6-log.tgz    | Bin 0 -> 133120 bytes
 swh/loader/svn/tests/test_loader.py                | 229 ++++-----------------
 3 files changed, 46 insertions(+), 184 deletions(-)
 create mode 100644 swh/loader/svn/tests/resources/pkg-gourmet-tampered-rev6-log.tgz
Changes applied before test
commit 393cd620d63ef32891ae6d028ab08a44c31ae411
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 14:17:02 2020 +0200

    svn.loader: Fix uneventful visit case
    
    It was unexpectedly "eventftul" so far [1]. Most probably since [2] [3] or
    something near.
    
    [1] https://forge.softwareheritage.org/D3399#inline-23571
    
    [2] https://forge.softwareheritage.org/D2887
    
    [3] https://forge.softwareheritage.org/D2889

commit db24c5eba543c871416500c7bd8ba79598a36ce0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 13:59:25 2020 +0200

    tests: Drop dead code
    
    Related to T2462

commit 01f9382e7442ef6510d016b7f7f42d6ac4c04b22
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 13:52:16 2020 +0200

    tests: Refactor repository with tampered information scenario
    
    This actually uses a real modified repository.
    
    Prior to this, this faked the alteration by modifying the input of the loader
    which is a hack.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/65/ for more details.

Tests refactoring which uncover bugs, nice !

oooohhhh yeah! ;)

This revision was automatically updated to reflect the committed changes.