Differential D3402

loader-svn: tests: Refactor scenario about starting from existing revision
ClosedPublic
Actions

Authored by ardumont on Jul 3 2020, 9:40 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2462: svn loader: Refactor tests using pytest fixtures

Commits

rDLDSVN58ae736a11d6: tests: Refactor scenario about starting from existing revision

Summary

This adds both check for the scenario about repository with or without changes:

With changes, visit the repository yields a new snapshot.
Without changes, visit the repository yields the same snapshot.

Related to T2462

Test Plan

tox

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 13293
Build 20309: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20308: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 3 2020, 9:40 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 3 2020, 9:40 AM

Build is green

Patch application report for D3402 (id=12056)

Could not rebase; Attempt merge onto ee23fd7582...

Updating ee23fd7..06ba4b2
Fast-forward
 requirements-test.txt               |   1 +
 swh/loader/svn/tests/conftest.py    |  15 +-
 swh/loader/svn/tests/test_loader.py | 521 ++++++++++++++++--------------------
 3 files changed, 243 insertions(+), 294 deletions(-)

Changes applied before test

commit 06ba4b2dac29bc4e36da3103ec2e143d9c6ff573
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:37:30 2020 +0200

    tests: Refactor scenario about starting from existing revision
    
    This adds both check for the scenario about repository with or without changes.
    
    Related to T2462

commit 036d3fdcd16101fa7a983c1f46a6fbf571daf8b7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:13:43 2020 +0200

    tests: Refactor start-from-scratch use case
    
    Related to T2462

commit 464d36c1a10cbd4e145186a7ad795596c3aa278f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 08:12:06 2020 +0200

    tests: Refactor scenario about visits on repository with changes
    
    For this, switch to using a pg storage to share the state amongst visit.
    
    Related to T2462

commit a846f61d164da4ee826ae2fcc48f965b307e6f67
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 07:29:35 2020 +0200

    tests: Refactor scenario about visits on repository with no change
    
    Related to T2462

commit 5d770ec3934b84413b13b63a19443592832c8e0a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 19:19:13 2020 +0200

    Start tests with pytest refactoring: Add scenario for 1 visit
    
    This starts to align the existing svn tests with the core/package ones. For
    now, utilities functions are in this repository close to the tests. They will
    most possibly be refactored out in swh-loader-core at some point.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/39/ for more details.

Harbormaster completed remote builds in B13277: Diff 12056.Jul 3 2020, 9:41 AM

Drop redundant tests (coverage did not bulge on production code after removing it)

Build is green

Patch application report for D3402 (id=12059)

Could not rebase; Attempt merge onto ee23fd7582...

Updating ee23fd7..284aacc
Fast-forward
 requirements-test.txt               |   1 +
 swh/loader/svn/tests/conftest.py    |  15 +-
 swh/loader/svn/tests/test_loader.py | 608 ++++++++++++++----------------------
 3 files changed, 241 insertions(+), 383 deletions(-)

Changes applied before test

commit 284aaccc2e168c2bd035a09390ce4c3c962c322e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:37:30 2020 +0200

    tests: Refactor scenario about starting from existing revision
    
    This adds both check for the scenario about repository with or without changes.
    
    Related to T2462

commit 036d3fdcd16101fa7a983c1f46a6fbf571daf8b7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:13:43 2020 +0200

    tests: Refactor start-from-scratch use case
    
    Related to T2462

commit 464d36c1a10cbd4e145186a7ad795596c3aa278f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 08:12:06 2020 +0200

    tests: Refactor scenario about visits on repository with changes
    
    For this, switch to using a pg storage to share the state amongst visit.
    
    Related to T2462

commit a846f61d164da4ee826ae2fcc48f965b307e6f67
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 07:29:35 2020 +0200

    tests: Refactor scenario about visits on repository with no change
    
    Related to T2462

commit 5d770ec3934b84413b13b63a19443592832c8e0a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 19:19:13 2020 +0200

    Start tests with pytest refactoring: Add scenario for 1 visit
    
    This starts to align the existing svn tests with the core/package ones. For
    now, utilities functions are in this repository close to the tests. They will
    most possibly be refactored out in swh-loader-core at some point.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/42/ for more details.

Harbormaster completed remote builds in B13280: Diff 12059.Jul 3 2020, 9:49 AM

ardumont edited the summary of this revision. (Show Details)Jul 3 2020, 10:13 AM

vlorentz accepted this revision.Jul 3 2020, 10:34 AM

This revision is now accepted and ready to land.Jul 3 2020, 10:34 AM

Rebase

Build is green

Patch application report for D3402 (id=12072)

Rebasing onto fca9e8b2af...

Current branch diff-target is up to date.

Changes applied before test

commit 58ae736a11d6d259c6b26885a1c7cf4f43f711b8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 09:37:30 2020 +0200

    tests: Refactor scenario about starting from existing revision
    
    This adds both check for the scenario about repository with or without changes.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/51/ for more details.

Harbormaster completed remote builds in B13293: Diff 12072.Jul 3 2020, 11:00 AM

Closed by commit rDLDSVN58ae736a11d6: tests: Refactor scenario about starting from existing revision (authored by ardumont). · Explain WhyJul 3 2020, 11:01 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDSVN58ae736a11d6: tests: Refactor scenario about starting from existing revision.