Page MenuHomeSoftware Heritage
Differential D3400

tests: Refactor scenario about visits on repository with changes
ClosedPublic
Actions

Authored by ardumont on Jul 3 2020, 8:12 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T2462: svn loader: Refactor tests using pytest fixtures
Commits
rDLDSVN7225c537e332: tests: Refactor scenario about visits on repository with changes
Summary

For this, switch to using a pg storage to share the state amongst visit.

Related to T2462

Test Plan

tox

Diff Detail

Event Timeline

ardumont created this revision.Jul 3 2020, 8:12 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 3 2020, 8:12 AM
swh-public-ci added a comment.Jul 3 2020, 8:13 AM

Build has FAILED

Patch application report for D3400 (id=12052)

Could not rebase; Attempt merge onto ee23fd7582...

Updating ee23fd7..cf77862
Fast-forward
 swh/loader/svn/tests/conftest.py    |  15 ++-
 swh/loader/svn/tests/test_loader.py | 233 ++++++++++++++++++++----------------
 2 files changed, 139 insertions(+), 109 deletions(-)
Changes applied before test
commit cf7786235e4aa152441b772820265347d1fd2ac4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 08:12:06 2020 +0200

    tests: Refactor scenario about visits on repository with changes
    
    For this, switch to using a pg storage to share the state amongst visit.
    
    Related to T2462

commit a846f61d164da4ee826ae2fcc48f965b307e6f67
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 07:29:35 2020 +0200

    tests: Refactor scenario about visits on repository with no change
    
    Related to T2462

commit 5d770ec3934b84413b13b63a19443592832c8e0a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 19:19:13 2020 +0200

    Start tests with pytest refactoring: Add scenario for 1 visit
    
    This starts to align the existing svn tests with the core/package ones. For
    now, utilities functions are in this repository close to the tests. They will
    most possibly be refactored out in swh-loader-core at some point.
    
    Related to T2462

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/35/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/35/console

Harbormaster failed remote builds in B13273: Diff 12052!Jul 3 2020, 8:13 AM
ardumont updated this revision to Diff 12053.Jul 3 2020, 9:11 AM

Add missing pytest-postgresql requirements

swh-public-ci added a comment.Jul 3 2020, 9:13 AM

Build is green

Patch application report for D3400 (id=12053)

Could not rebase; Attempt merge onto ee23fd7582...

Updating ee23fd7..388f2e8
Fast-forward
 requirements-test.txt               |   1 +
 swh/loader/svn/tests/conftest.py    |  15 ++-
 swh/loader/svn/tests/test_loader.py | 233 ++++++++++++++++++++----------------
 3 files changed, 140 insertions(+), 109 deletions(-)
Changes applied before test
commit 388f2e854cb598169c70772b1d39aeb3cb172dce
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 08:12:06 2020 +0200

    tests: Refactor scenario about visits on repository with changes
    
    For this, switch to using a pg storage to share the state amongst visit.
    
    Related to T2462

commit a846f61d164da4ee826ae2fcc48f965b307e6f67
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 07:29:35 2020 +0200

    tests: Refactor scenario about visits on repository with no change
    
    Related to T2462

commit 5d770ec3934b84413b13b63a19443592832c8e0a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 19:19:13 2020 +0200

    Start tests with pytest refactoring: Add scenario for 1 visit
    
    This starts to align the existing svn tests with the core/package ones. For
    now, utilities functions are in this repository close to the tests. They will
    most possibly be refactored out in swh-loader-core at some point.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/36/ for more details.

Harbormaster completed remote builds in B13274: Diff 12053.Jul 3 2020, 9:13 AM
ardumont updated this revision to Diff 12058.Jul 3 2020, 9:41 AM

Drop redundant scenario (already tested within that scope)

swh-public-ci added a comment.Jul 3 2020, 9:44 AM

Build is green

Patch application report for D3400 (id=12058)

Could not rebase; Attempt merge onto ee23fd7582...

Updating ee23fd7..464d36c
Fast-forward
 requirements-test.txt               |   1 +
 swh/loader/svn/tests/conftest.py    |  15 +-
 swh/loader/svn/tests/test_loader.py | 308 +++++++++++++++---------------------
 3 files changed, 140 insertions(+), 184 deletions(-)
Changes applied before test
commit 464d36c1a10cbd4e145186a7ad795596c3aa278f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 08:12:06 2020 +0200

    tests: Refactor scenario about visits on repository with changes
    
    For this, switch to using a pg storage to share the state amongst visit.
    
    Related to T2462

commit a846f61d164da4ee826ae2fcc48f965b307e6f67
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 07:29:35 2020 +0200

    tests: Refactor scenario about visits on repository with no change
    
    Related to T2462

commit 5d770ec3934b84413b13b63a19443592832c8e0a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 2 19:19:13 2020 +0200

    Start tests with pytest refactoring: Add scenario for 1 visit
    
    This starts to align the existing svn tests with the core/package ones. For
    now, utilities functions are in this repository close to the tests. They will
    most possibly be refactored out in swh-loader-core at some point.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/41/ for more details.

Harbormaster completed remote builds in B13279: Diff 12058.Jul 3 2020, 9:44 AM
vlorentz accepted this revision.Jul 3 2020, 10:08 AM
This revision is now accepted and ready to land.Jul 3 2020, 10:08 AM
ardumont updated this revision to Diff 12067.Jul 3 2020, 10:49 AM

Rebase

swh-public-ci added a comment.Jul 3 2020, 10:51 AM

Build is green

Patch application report for D3400 (id=12067)

Rebasing onto 58bb1e4685...

Current branch diff-target is up to date.
Changes applied before test
commit 7225c537e3322923ef521564ef5b6787bd2a440c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 08:12:06 2020 +0200

    tests: Refactor scenario about visits on repository with changes
    
    For this, switch to using a pg storage to share the state amongst visit.
    
    Related to T2462

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/48/ for more details.

Harbormaster completed remote builds in B13288: Diff 12067.Jul 3 2020, 10:51 AM
Closed by commit rDLDSVN7225c537e332: tests: Refactor scenario about visits on repository with changes (authored by ardumont). · Explain WhyJul 3 2020, 10:51 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDSVN7225c537e332: tests: Refactor scenario about visits on repository with changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
1 line--
swh/
loader/
svn/
tests/
6 lines100%
Loading...
166 lines99%
Loading...

Diff 12058

View Options

requirements-test.txt

Loading...
View Options

swh/loader/svn/tests/conftest.py

Loading...
View Options

swh/loader/svn/tests/test_loader.py

Loading...
About · Developer information · Legal