Page MenuHomeSoftware Heritage

admin/deposit: Filter out deposit entries server side
ClosedPublic

Authored by anlambert on Tue, Jun 30, 11:45 AM.

Details

Summary

Prefer to filter out deposit entries server side by sending the Exclude value
in data requests.

Also make UI more compact using CSS Flex rules.

Closes T2406

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Tue, Jun 30, 11:45 AM

Cool, I did not see how to properly do that.

But that was my initial intent thus why i opened the option deposit side ;)

ardumont accepted this revision.Tue, Jun 30, 11:54 AM
This revision is now accepted and ready to land.Tue, Jun 30, 11:54 AM

Build is green

Patch application report for D3374 (id=11974)

Rebasing onto 9be63da1dd...

Current branch diff-target is up to date.
Changes applied before test
commit d4e37c158bc2d873ae5ce7c6b18003895377f85a
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Jun 30 11:41:00 2020 +0200

    admin/deposit: Filter out deposit entries server side
    
    Prefer to filter out deposit entries server side by sending the Exclude value
    in data requests.
    
    Also make UI more compact using CSS Flex rules.
    
    Closes T2406

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/245/ for more details.

Cool, I did not see how to properly do that.

But that was my initial intent thus why i opened the option deposit side ;)

Yes, datatables documentation is so large, it is easy to miss the server side feature.

I should have added a new Python test but I am not in the mood for a mocking party ;-)

Yes, datatables documentation is so large, it is easy to miss the server side feature.

yes! I spent a lot of time on it already.
And at a time, i did spent a lot of time with cypress as well (which is also large ;).

I should have added a new Python test but I am not in the mood for a mocking party ;-)

yeah, i guessed as much.
I'm not too worry about that, it will turn up at some point ;)

Cheers,