Since the upgrade to bootstrap 4.5.0, the buttons layout in diff views was broken.
Some deprecated CSS classes were used and have been removed in that release.
So use correct CSS classes to fix the layout.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDWAPPSa40184b5dba3: assets/revision/diff-utils: Fix buttons layout in diff views
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13168 Build 20101: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 20100: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D3369 (id=11953)
Rebasing onto 1f756f7fa7...
Current branch diff-target is up to date.
Changes applied before test
commit a40184b5dba35627eb83a596a0746402d36bafee Author: Antoine Lambert <antoine.lambert@inria.fr> Date: Mon Jun 29 11:44:41 2020 +0200 assets/revision/diff-utils: Fix buttons layout in diff views Since the upgrade to bootstrap 4.5.0, the buttons layout in diff views was broken. Some deprecated CSS classes were used and have been removed in that release. So use correct CSS classes to fix the layout.
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/237/ for more details.