Differential D3369

diff-utils: Fix buttons layout in diff views
ClosedPublic
Actions

Authored by anlambert on Jun 29 2020, 11:47 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPSa40184b5dba3: assets/revision/diff-utils: Fix buttons layout in diff views

Summary

Since the upgrade to bootstrap 4.5.0, the buttons layout in diff views was broken.
Some deprecated CSS classes were used and have been removed in that release.
So use correct CSS classes to fix the layout.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jun 29 2020, 11:47 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 29 2020, 11:47 AM

ardumont accepted this revision.Jun 29 2020, 11:49 AM

This revision is now accepted and ready to land.Jun 29 2020, 11:49 AM

Build is green

Patch application report for D3369 (id=11953)

Rebasing onto 1f756f7fa7...

Current branch diff-target is up to date.

Changes applied before test

commit a40184b5dba35627eb83a596a0746402d36bafee
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Jun 29 11:44:41 2020 +0200

    assets/revision/diff-utils: Fix buttons layout in diff views
    
    Since the upgrade to bootstrap 4.5.0, the buttons layout in diff views was broken.
    Some deprecated CSS classes were used and have been removed in that release.
    So use correct CSS classes to fix the layout.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/237/ for more details.

Harbormaster completed remote builds in B13168: Diff 11953.Jun 29 2020, 12:01 PM

Closed by commit rDWAPPSa40184b5dba3: assets/revision/diff-utils: Fix buttons layout in diff views (authored by anlambert). · Explain WhyJun 29 2020, 1:06 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSa40184b5dba3: assets/revision/diff-utils: Fix buttons layout in diff views.