Page MenuHomeSoftware Heritage

assets/revision/diff-utils: Fix buttons layout in diff views
ClosedPublic

Authored by anlambert on Mon, Jun 29, 11:47 AM.

Details

Summary

Since the upgrade to bootstrap 4.5.0, the buttons layout in diff views was broken.
Some deprecated CSS classes were used and have been removed in that release.
So use correct CSS classes to fix the layout.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mon, Jun 29, 11:47 AM
ardumont accepted this revision.Mon, Jun 29, 11:49 AM
This revision is now accepted and ready to land.Mon, Jun 29, 11:49 AM

Build is green

Patch application report for D3369 (id=11953)

Rebasing onto 1f756f7fa7...

Current branch diff-target is up to date.
Changes applied before test
commit a40184b5dba35627eb83a596a0746402d36bafee
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Jun 29 11:44:41 2020 +0200

    assets/revision/diff-utils: Fix buttons layout in diff views
    
    Since the upgrade to bootstrap 4.5.0, the buttons layout in diff views was broken.
    Some deprecated CSS classes were used and have been removed in that release.
    So use correct CSS classes to fix the layout.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/237/ for more details.