Page MenuHomeSoftware Heritage

swh.model.model.OriginVisit: Drop the dateutil.parser.parse use
ClosedPublic

Authored by ardumont on Jun 22 2020, 6:13 PM.

Details

Summary

I'm planning on dropping unnecessary fields on the OriginVisit model object [1]

So it's a good time to drop this since i'll pass everywhere anyway.

This is in accordance to a discussion about phasing out dateutil.parser.parse_date in favor of using either iso-8601 datestrings or directly datetime.
Here the fields is supposed to be datetime anyway.

What do you think?

[1] D3337

Test Plan

tox

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jun 22 2020, 6:13 PM

Build is green

Patch application report for D3336 (id=11820)

Rebasing onto ba0c4e19e6...

Current branch diff-target is up to date.
Changes applied before test
commit f349bdc628bd85a5904a3620b2cc3ca2324f6b42
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 22 10:14:30 2020 +0200

    swh.model.model.OriginVisit: Drop the dateutil.parser.parse use

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/75/ for more details.

ardumont edited the summary of this revision. (Show Details)Jun 22 2020, 6:16 PM
ardumont edited the summary of this revision. (Show Details)
vlorentz accepted this revision.Jun 23 2020, 12:17 PM
This revision is now accepted and ready to land.Jun 23 2020, 12:17 PM