Differential D3345

journal: Drop datetime conversion indirection
ClosedPublic
Actions

Authored by ardumont on Jun 24 2020, 1:41 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDJNL84641aeddc39: Drop datetime conversion indirection

Summary

When nullifying [1] the origin-visit fields, i came across that code which
is no longer necessary.

That is even the source of trouble in diffs and master. [3]
It's most possibly introduced by [2]

[1] Depends on D3344

[2] D3336

[3] https://jenkins.softwareheritage.org/job/DSTO/job/tests/1298/console
https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/347/testReport/junit/.tox.py3.lib.python3.7.site-packages.swh.storage.tests/test_backfill/test_backfiller/

Test Plan

tox

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jun 24 2020, 1:41 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 24 2020, 1:41 PM

Build is green

Patch application report for D3345 (id=11858)

Could not rebase; Attempt merge onto 6ea2d6e4c8...

Updating 6ea2d6e..cc6d526
Fast-forward
 swh/journal/pytest_plugin.py      |  3 --
 swh/journal/tests/journal_data.py | 73 ++++++++++++++++++++++++++-------------
 swh/journal/writer/kafka.py       |  3 --
 3 files changed, 49 insertions(+), 30 deletions(-)

Changes applied before test

commit cc6d526eb3c5547d21f2c01a67f17f40ca684775
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 24 13:41:14 2020 +0200

    Drop unnecessary datetime conversion

commit 7d3d0062c9b63d72ff1033fdbad5b4a0b009209f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 24 13:38:30 2020 +0200

    journal_data: Make origin-visit optional fields to None
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/93/ for more details.

Harbormaster completed remote builds in B13073: Diff 11858.Jun 24 2020, 1:43 PM

Rebase

Build is green

Patch application report for D3345 (id=11877)

Rebasing onto 4c7d945492...

Current branch diff-target is up to date.

Changes applied before test

commit 25c89e1dab6d1c5807c25fd0bb2907ee9e6ac5d7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 24 13:41:14 2020 +0200

    Drop unnecessary datetime conversion

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/97/ for more details.

Harbormaster completed remote builds in B13091: Diff 11877.Jun 25 2020, 9:33 AM

ardumont edited the summary of this revision. (Show Details)Jun 25 2020, 9:56 AM

ardumont retitled this revision from journal: Drop unnecessary datetime conversion? to journal: Drop datetime conversion indirection.

Rework commit message

Build is green

Patch application report for D3345 (id=11878)

Rebasing onto 4c7d945492...

Current branch diff-target is up to date.

Changes applied before test

commit 84641aeddc398e16bf878cbff5857149c874fc41
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 24 13:41:14 2020 +0200

    Drop datetime conversion indirection
    
    As this is no longer compatible with latest model, that code makes the storage
    builds fail.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/98/ for more details.

Harbormaster completed remote builds in B13092: Diff 11878.Jun 25 2020, 10:06 AM

ardumont edited the summary of this revision. (Show Details)Jun 25 2020, 10:07 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 25 2020, 10:09 AM

Closed by commit rDJNL84641aeddc39: Drop datetime conversion indirection (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDJNL84641aeddc39: Drop datetime conversion indirection.

ardumont mentioned this in D3342: storage*: Drop obsolete fields from origin_visit.Jun 25 2020, 11:03 AM

ardumont edited the summary of this revision. (Show Details)

ardumont mentioned this in D3351: replayer: Fix isoformat datetime string for origin-visit.Jun 25 2020, 11:22 AM

ardumont mentioned this in rDSTOc6e6f33916aa: replayer: Fix isoformat datetime string for origin-visit.Jun 25 2020, 2:33 PM