test_api_client: stop leaking directories
ClosedPublic
Actions

Authored by olasd on May 11 2018, 3:42 PM.

Details

Reviewers

Group Reviewers

Commits

rDSTOC4a9b6236015d: test_api_client: stop leaking directories
R65:4a9b6236015d: test_api_client: stop leaking directories
rDSTO4a9b6236015d: test_api_client: stop leaking directories

Summary

When mkdtemp is called, shutil.rmtree must be called as well

Test Plan

Look at /tmp before and after running tests, notice no new
directories instead of 60.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1229
Build 1573: arc lint + arc unit

Event Timeline

olasd created this revision.May 11 2018, 3:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 11 2018, 3:42 PM

Harbormaster completed remote builds in B1229: Diff 1065.May 11 2018, 3:42 PM

ardumont accepted this revision.May 11 2018, 5:44 PM

This revision is now accepted and ready to land.May 11 2018, 5:44 PM

Closed by commit rDSTO4a9b6236015d: test_api_client: stop leaking directories (authored by olasd). · Explain WhyMay 12 2018, 5:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

tests/

test_api_client.py

15 lines

Diff 1065

View Options

swh/storage/tests/test_api_client.py

test_api_client: stop leaking directoriesClosedPublicActions