Page MenuHomeSoftware Heritage

model.hypothesis_strategies: Make metadata always none on origin_visit
ClosedPublic

Authored by ardumont on Jun 16 2020, 7:16 PM.

Details

Summary
  1. This is not currently not used in production.
  1. This is broken storage side [1]
  1. And finally, this is temporary as this will soon go away with T2310 [2]

[1] origin-visit-add does not deal correctly with metadata
(origin-visit-status-add does it well though). And it so happens there is no
test around it... So unfortunately it only got detected by @douardda's run with
the backfiller or something. It's good it got detected though ¯\_(ツ)_/¯

[2] we are currently phasing out multiple origin-visit fields including this
one

Test Plan

tox

Diff Detail

Repository
rDMOD Data model
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12883
Build 19615: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 19614: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3294 (id=11675)

Rebasing onto f723eb12af...

Current branch diff-target is up to date.
Changes applied before test
commit ba0c4e19e6b01f0c9585832f7fe430975f48ab8c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jun 16 19:10:53 2020 +0200

    model.hypothesis_strategies: Make metadata always none on origin_visit
    
    This is not used. This is broken storage wise (origin-visit-add does not deal
    correctly with it and it so happens there is no test around it).
    
    And finally, this will soon go away with T2310.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/74/ for more details.

This revision is now accepted and ready to land.Jun 17 2020, 9:30 AM