Add a top border of 3px colored with the SWH theme red for nicer display
Before:
After:
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDWAPPS2d0db7f23a41: assets/webapp.css: Improve active nav tab stylesheets
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Nice.
Isn't it a bit too large though (question based solely from the rendering of the associated image)?
(I would have changed only the color and keep the larger of 1px at first. You know better so fine ;)
Comment Actions
Build is green
Patch application report for D3282 (id=11642)
Rebasing onto bfd6665bf7...
Current branch diff-target is up to date.
Changes applied before test
commit 2d0db7f23a41d02a458a941a4134c659926dc735
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Mon Jun 15 13:54:05 2020 +0200
assets/webapp.css: Improve active nav tab stylesheets
Add a top border of 3px colored with the SWH theme red for nicer displaySee https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/183/ for more details.
Comment Actions
Isn't it a bit too large though (question based solely from the rendering of the associated image)?
3px is the right value to get a nice selection effect (Github UI uses the same value for instance).