Page MenuHomeSoftware Heritage

test_cli: Mock iso8601 behavior in test
AbandonedPublic

Authored by ardumont on Jun 12 2020, 3:56 PM.

Details

Reviewers
anlambert
olasd
Group Reviewers
Reviewers
Summary
Test Plan

tox

Diff Detail

Event Timeline

Build is green

Patch application report for D3274 (id=11615)

Rebasing onto 3df7462ad7...

Current branch diff-target is up to date.
Changes applied before test
commit d90b02df53a879ade4c0947dbfe8055f4e51c61a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 12 15:56:02 2020 +0200

    test_cli: Mock iso8601 behavior in test
    
    This should unblock the current debian package build issue [1]
    
    [1] https://jenkins.softwareheritage.org/view/Debian%20packages/job/debian/job/packages/job/DLDBASE/job/gbp-buildpackage/135/

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/70/ for more details.

olasd requested changes to this revision.Jun 12 2020, 4:04 PM
olasd added a subscriber: olasd.

While this is indeed a fringe use case, having swh loader run fail to parse timezone information in the fixed visit date is an actual bug (in some combination of debian package versions) that needs actual fixing. I don't think a commit masking the bug is the right way to go...

This revision now requires changes to proceed.Jun 12 2020, 4:04 PM

While this is indeed a fringe use case, having swh loader run fail to parse
timezone information in the fixed visit date is an actual bug (in some
combination of debian package versions) that needs actual fixing. I don't
think a commit masking the bug is the right way to go...

Sure, i did not have the notion that i was doing that.

Thanks for insisting on that (and sorry you had to :)

Proper fix is P697 (missing quote around input_date ¯\_(ツ)_/¯)