Alongside swh.model.model, this allows us to define data models for the objects
the scheduler is working with, and to serialize/deserialize these objects
transparently at the RPC layer.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDSCHc509a12df5f1: Introduce some scaffolding for an attrs-based BaseSchedulerModel
no specific tox tests added; these will come when actual models will
happen in further commits
Diff Detail
Diff Detail
- Repository
- rDSCH Scheduling utilities
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12799 Build 19476: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 19475: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D3270 (id=11594)
Rebasing onto 4c0c37bab0...
Current branch diff-target is up to date.
Changes applied before test
commit 2eb7a2e07197faa5423b47d7f08111e553db0c71
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date: Fri Jun 12 11:03:26 2020 +0200
Introduce some scaffolding for an attrs-based BaseSchedulerModel
Alongside swh.model.model, this allows us to define data models for the objects
the scheduler is working with, and to serialize/deserialize these objects
transparently at the RPC layer.See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/18/ for more details.
Comment Actions
This looks fine to me.
One question above.
| swh/scheduler/model.py | ||
|---|---|---|
| 26 | I gather that's a generic definition declaration for the future scheduler model classes... Oh is that to ensure the order of the columns is always the same? | |
Comment Actions
Build is green
Patch application report for D3270 (id=11601)
Rebasing onto 4c0c37bab0...
Current branch diff-target is up to date.
Changes applied before test
commit c6054ae5f029f1c5c73120bb7252e7968f81b9fc
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date: Fri Jun 12 11:03:26 2020 +0200
Introduce some scaffolding for an attrs-based BaseSchedulerModel
Alongside swh.model.model, this allows us to define data models for the objects
the scheduler is working with, and to serialize/deserialize these objects
transparently at the RPC layer.
This also introduces some mild ORM-like logic so we can keep the actual SQL a
little DRYer.See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/20/ for more details.
| swh/scheduler/model.py | ||
|---|---|---|
| 26 | Yeah. I've added a docstring and some tests to clarify the intent. | |
| swh/scheduler/api/serializers.py | ||
|---|---|---|
| 17 | Possibly. But that won't help for the DECODERS entry | |
| swh/scheduler/model.py | ||
| 34 | This one comes from attrs, I didn't do it! | |
| swh/scheduler/tests/test_model.py | ||
| 23 ↗ | (On Diff #11601) | Making sure random properties don't show up in the SQL, only actual fields. I'll add a docstring. |
| swh/scheduler/tests/test_model.py | ||
|---|---|---|
| 23 ↗ | (On Diff #11601) | isn't this a "poor man's test" for attr.fields()? |
| swh/scheduler/api/serializers.py | ||
|---|---|---|
| 17 | ok, since this is for now completely circumscribed(?) in the scheduler, we can postpone this discussion for a later time if necessary, I guess. | |
Comment Actions
Build is green
Patch application report for D3270 (id=11631)
Rebasing onto 4c0c37bab0...
Current branch diff-target is up to date.
Changes applied before test
commit c509a12df5f1c25be3e492c693be11eae382862a
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date: Fri Jun 12 11:03:26 2020 +0200
Introduce some scaffolding for an attrs-based BaseSchedulerModel
Alongside swh.model.model, this allows us to define data models for the objects
the scheduler is working with, and to serialize/deserialize these objects
transparently at the RPC layer.
This also introduces some mild ORM-like logic so we can keep the actual SQL a
little DRYer.See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/24/ for more details.