UnicodeDecodeError is already handled in loader implementation when
a property content is not UTF-8 encoded so we can safely use that
svnadmin load option.
Closes T2395
Details
Details
- Reviewers
ardumont olasd - Group Reviewers
Reviewers - Maniphest Tasks
- T2395: Save code now fails on a svn project
- Commits
- rDLDSVNeaf7a927c8b8: utils: Bypass properties validation with "svnadmin load"
Diff Detail
Diff Detail
- Repository
- rDLDSVN Subversion (SVN) loader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D3209 (id=11387)
Rebasing onto f934581b20...
Current branch diff-target is up to date.
Changes applied before test
commit a761f0c330dd08c974d3b3ab603bdc2549cca555
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Tue Jun 2 19:03:05 2020 +0200
utils: Bypass properties validation with "svnadmin load"
UnicodeDecodeError is already handled in loader implementation when
a property content is not UTF-8 encoded so we can safely use that
svnadmin load option.
Closes T2395See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/7/ for more details.
Comment Actions
Looks reasonable to me.
UnicodeDecodeError is already handled in loader implementation when
a property content is not UTF-8 encoded so we can safely use that
svnadmin load option.
I assume you are referring to the extra "replay agent" (ra) codec ;) [1]
[1] https://forge.softwareheritage.org/source/swh-loader-svn/browse/master/swh/loader/svn/ra.py$109-119
[2] https://forge.softwareheritage.org/source/swh-loader-svn/browse/master/swh/loader/svn/ra.py$437
Comment Actions
Could you add a comment next to the command to say what you're saying in the commit message?
Ideally we'd also add a test "fixture" with some invalid props, but I don't know how convenient it'd be to add to the existing test repos.
Comment Actions
Build was aborted
Patch application report for D3209 (id=11389)
Rebasing onto a1a10d2da8...
First, rewinding head to replay your work on top of it... Applying: utils: Bypass properties validation with "svnadmin load"
Changes applied before test
commit 58d2e72f2cb6f68d4a760820447b0842cdaa5ecc
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Tue Jun 2 19:03:05 2020 +0200
utils: Bypass properties validation with "svnadmin load"
UnicodeDecodeError is already handled in loader implementation when
a property content is not UTF-8 encoded so we can safely use that
svnadmin load option.
Closes T2395Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/8/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/8/console
Comment Actions
Build is green
Patch application report for D3209 (id=11389)
Rebasing onto a1a10d2da8...
First, rewinding head to replay your work on top of it... Applying: utils: Bypass properties validation with "svnadmin load"
Changes applied before test
commit 83bb42aa8958d8b309f46391eeb05d83160d8cc7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Tue Jun 2 19:03:05 2020 +0200
utils: Bypass properties validation with "svnadmin load"
UnicodeDecodeError is already handled in loader implementation when
a property content is not UTF-8 encoded so we can safely use that
svnadmin load option.
Closes T2395See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/9/ for more details.
Comment Actions
Build is green
Patch application report for D3209 (id=11392)
Rebasing onto a1a10d2da8...
Current branch diff-target is up to date.
Changes applied before test
commit eaf7a927c8b8e943dd18ddd344c5c19428e77cee
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Tue Jun 2 19:03:05 2020 +0200
utils: Bypass properties validation with "svnadmin load"
UnicodeDecodeError is already handled in loader implementation when
a property content is not UTF-8 encoded so we can safely use that
svnadmin load option.
Closes T2395See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/10/ for more details.