This fixes the ci build [1]
[1] https://jenkins.softwareheritage.org/job/DWAPPS/job/tests/1343/console
(To ensure this actually fixes it in jenkins, not reproduced locally)
Details
Details
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D3145 (id=11167)
Rebasing onto 23f07024a2...
Current branch diff-target is up to date.
Changes applied before test
commit 2af8b9ed7ad77393f5743d963dd3fa0102d4632f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Tue May 12 18:02:06 2020 +0200
Fix pep8 violations
This fixes the ci build [1]
[1] https://jenkins.softwareheritage.org/job/DWAPPS/job/tests/1343/consoleLink to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/124/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/124/console
Comment Actions
Build is green
Patch application report for D3145 (id=11168)
Rebasing onto 23f07024a2...
Current branch diff-target is up to date.
Changes applied before test
commit 3bbc62e22745145ec1097970303b16055e4e4bb5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Tue May 12 18:02:06 2020 +0200
Fix pep8 violations
This fixes the ci build [1]
[1] https://jenkins.softwareheritage.org/job/DWAPPS/job/tests/1343/consoleSee https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/125/ for more details.
Comment Actions
Thanks for the fixes. TIL that I should run pre-commit autoupdate on a regular basis.
(swh) ✔ ~/swh/swh-environment/swh-web [master ↓·1|⚑ 178] 19:07 $ pre-commit autoupdate Updating https://github.com/pre-commit/pre-commit-hooks...[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. updating v2.4.0 -> v2.5.0. Updating https://github.com/codespell-project/codespell...already up to date. Updating https://github.com/python/black...already up to date. (swh) ✔ ~/swh/swh-environment/swh-web [master ↓·1|✚ 1⚑ 178] 19:07 $ make check pre-commit run --all-files [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Trim Trailing Whitespace.................................................Passed Flake8 (deprecated, use gitlab.com/pycqa/flake8).........................Failed hookid: flake8 swh/web/tests/auth/test_api_auth.py:85:47: F541 f-string is missing placeholders swh/web/tests/auth/test_api_auth.py:109:47: F541 f-string is missing placeholders swh/web/tests/browse/views/test_origin.py:675:17: F541 f-string is missing placeholders swh/web/tests/auth/test_backends.py:124:33: F541 f-string is missing placeholders swh/web/tests/auth/test_backends.py:139:63: F541 f-string is missing placeholders swh/web/common/service.py:34:20: E741 ambiguous variable name 'l' Check JSON...............................................................Passed Check Yaml...............................................................Passed codespell................................................................Passed mypy.....................................................................Passed eslint...................................................................Passed black....................................................................Passed make: *** [../Makefile.python:28: check] Error 1