Page MenuHomeSoftware Heritage
Differential D3079

tests: Fix execution after swh-storage update
ClosedPublic
Actions

Authored by anlambert on Apr 29 2020, 11:50 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS16a3ea07e577: tests: Fix execution after swh-storage update
Summary

Literal date string must be in valid ISO 8601 format afer recent storage updates.

swh/web/tests/browse/views/test_content.py:35: in <module>
    @given(content_text())
swh/web/tests/strategies.py:101: in content_text
    return content().filter(lambda c: c["mimetype"].startswith("text/"))
swh/web/tests/strategies.py:85: in content
    return _known_swh_object("contents")
swh/web/tests/strategies.py:56: in _known_swh_object
    return sampled_from(get_tests_data()[object_type])
swh/web/tests/data.py:300: in get_tests_data
    _tests_data = _init_tests_data()
swh/web/tests/data.py:181: in _init_tests_data
    snapshot=hash_to_bytes("1a8893e6a86f444e8be8e7bda6cb34fb1735a00e"),
../swh-storage/swh/storage/in_memory.py:862: in origin_visit_update
    self._origin_visit_get_updated(origin_url, visit_id)
../swh-storage/swh/storage/in_memory.py:918: in _origin_visit_get_updated
    visit_update = max(self._origin_visit_statuses[visit_key], key=lambda v: v.date)
E   TypeError: can't compare offset-naive and offset-aware datetimes

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 29 2020, 11:50 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 29 2020, 11:50 AM
anlambert updated this revision to Diff 10969.Apr 29 2020, 11:51 AM

Fix typo in commit message

vlorentz added a subscriber: vlorentz.Apr 29 2020, 11:54 AM

Do you know what update, specifically?

And why did it work so far?

swh-public-ci added a comment.Apr 29 2020, 11:58 AM

Build is green

Patch application report for D3079 (id=10968)

Rebasing onto 7f3329dca2...

Current branch diff-target is up to date.
Changes applied before test
commit 7babbb8568f1df45082b18d652af15349a494053
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 11:47:48 2020 +0200

    tests: Fix execution after swh-storage update
    
    Litteral date strings must be in ISO 8601 format.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/89/ for more details.

Harbormaster completed remote builds in B12120: Diff 10968.Apr 29 2020, 11:58 AM
anlambert added a comment.Apr 29 2020, 12:02 PM
In D3079#74963, @vlorentz wrote:

Do you know what update, specifically?

And why did it work so far?

I guess the change of behavior comes from that commit rDSTOead80889fb44d7c0e929b913f3e852ab851c0a3d,
origin visit format is now checked by swh-model objects.

vlorentz added a comment.Apr 29 2020, 12:02 PM

if this commit changes any behavior, then it's a bug

vlorentz accepted this revision.Apr 29 2020, 12:04 PM

Hmm you're right, it's using now() in addition to a supplied datetime now.

I'll try to make a diff to forbid naive datetimes, like we should always have

This revision is now accepted and ready to land.Apr 29 2020, 12:04 PM
swh-public-ci added a comment.Apr 29 2020, 12:06 PM

Build is green

Patch application report for D3079 (id=10969)

Rebasing onto 7f3329dca2...

Current branch diff-target is up to date.
Changes applied before test
commit 16a3ea07e577be29ab9f6d08810591746ddb427c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 11:47:48 2020 +0200

    tests: Fix execution after swh-storage update
    
    Literal date strings must be in ISO 8601 format.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/90/ for more details.

Harbormaster completed remote builds in B12121: Diff 10969.Apr 29 2020, 12:06 PM
anlambert added a comment.Apr 29 2020, 12:06 PM
In D3079#74970, @vlorentz wrote:

Hmm you're right, it's using now() in addition to a supplied datetime now.

I'll try to make a diff to forbid naive datetimes, like we should always have

Ack, I have a similar task for the webapp opened on the subject by the way (T2375).

ardumont added a subscriber: ardumont.Apr 29 2020, 12:06 PM

How come?
I did not tag it yet?

oh with pytest?

anlambert added a comment.Apr 29 2020, 12:08 PM

oh with pytest?

Yep, mr update is the first thing I do every morning ;-)

Closed by commit rDWAPPS16a3ea07e577: tests: Fix execution after swh-storage update (authored by anlambert). · Explain WhyApr 29 2020, 12:13 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS16a3ea07e577: tests: Fix execution after swh-storage update.
vlorentz added a comment.Apr 29 2020, 1:06 PM
In D3079#74970, @vlorentz wrote:

I'll try to make a diff to forbid naive datetimes, like we should always have

D3084, but it's only at the RPC layer, so it wouldn't have caught this.

Revision Contents
Changeset List

PathSize
swh/
web/
tests/
2 lines

Diff 10971

View Options

swh/web/tests/data.py

Loading...
About · Developer information · Legal