Fix a regression inroduced in 09e18940394e: when a revision id is null (for
instance when browsing an empty snapshot), do not attempt to lookup revision
data to avoid an error 500.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDWAPPSb6448adfe411: browse/snapshot_context: Do not lookup null revision in directory view
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12037 Build 18256: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 18255: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D3059 (id=10885)
Rebasing onto 98d53fedce...
Current branch diff-target is up to date.
Changes applied before test
commit c5ae7c410bffcffe77734f40f01e831ee4c5dbbd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Fri Apr 24 11:58:20 2020 +0200
browse/snapshot_context: Do not lookup null revision in directory view
Fix a regression inroduced in 09e18940394e: when a revision id is null (for
instance when browsing an empty snapshot), do not attempt to lookup revision
data to avoid an error 500.See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/81/ for more details.
Comment Actions
Build has FAILED
Patch application report for D3059 (id=10886)
Rebasing onto b6448adfe4...
First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-82-D3059.
Changes applied before test
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/82/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/82/console