Page MenuHomeSoftware Heritage

browse/snapshot_context: Do not lookup null revision in directory view
ClosedPublic

Authored by anlambert on Apr 24 2020, 11:59 AM.

Details

Summary

Fix a regression inroduced in 09e18940394e: when a revision id is null (for
instance when browsing an empty snapshot), do not attempt to lookup revision
data to avoid an error 500.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Update: Use "is not None" syntax

This revision is now accepted and ready to land.Apr 24 2020, 12:02 PM
This revision was landed with ongoing or failed builds.Apr 24 2020, 12:04 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D3059 (id=10885)

Rebasing onto 98d53fedce...

Current branch diff-target is up to date.
Changes applied before test
commit c5ae7c410bffcffe77734f40f01e831ee4c5dbbd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Apr 24 11:58:20 2020 +0200

    browse/snapshot_context: Do not lookup null revision in directory view
    
    Fix a regression inroduced in 09e18940394e: when a revision id is null (for
    instance when browsing an empty snapshot), do not attempt to lookup revision
    data to avoid an error 500.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/81/ for more details.

Build has FAILED

Patch application report for D3059 (id=10886)

Rebasing onto b6448adfe4...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-82-D3059.
Changes applied before test

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/82/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/82/console