docker: fixes and cleanup
ClosedPublic
Actions

Authored by anlambert on Apr 23 2020, 3:26 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDENVfab1a69166fa: docker/services: Add missing waits for swh-scheduler service
rDENV01f235f9c1b8: docker/tests/loader_git: Stop waiting task termination on traceback
rDENV808f1d6e47d4: docker/Dockerfile: Remove no more needed pip instructions

Summary

A couple of fixes and stability improvements for the docker environment.

commit d64cdff82b73a1d4ec530909f1a23af95037ddd9 (HEAD -> master)
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 23 15:23:13 2020 +0200

    docker/tests/loader_git: Stop waiting task termination on traceback

commit 4e92003c8bced452a06d1faf723c2ba142c53b7c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 23 15:16:33 2020 +0200

    docker/services: Add missing waits for swh-scheduler service
    
    We need to ensure scheduler service is up before celery workers attempt to create
    scheduler task types.

commit d1658711d0217315eaf62e0a822137339609f1b7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 23 15:11:38 2020 +0200

    docker/Dockerfile: Remove no more needed pip instructions
    
    cassandra-driver now has a binary wheel and Django 2.x is now used

Diff Detail

Repository

rDENV Development environment

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 23 2020, 3:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 23 2020, 3:26 PM

Harbormaster completed remote builds in B12012: Diff 10858.Apr 23 2020, 3:26 PM

ardumont accepted this revision.Apr 23 2020, 3:28 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

docker/tests/test_01_loader_git.sh
13 ↗	(On Diff #10858)	why adding the traceback?

This revision is now accepted and ready to land.Apr 23 2020, 3:28 PM

anlambert added inline comments.Apr 23 2020, 3:51 PM

docker/tests/test_01_loader_git.sh
13 ↗	(On Diff #10858)	To stop waiting immediately if an error occurs when loading a git repo. In P653, the kafka error output messed up the greping of `swh.loader.git.tasks.UpdateGitRepository.*succeeded` so greping Traceback can help in those situations.