Page MenuHomeSoftware Heritage

core: setup: Update the minimum required runtime python3 version
ClosedPublic

Authored by ardumont on Apr 20 2020, 11:55 AM.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D3031 (id=10763)

Rebasing onto dca9c5fc66...

Current branch diff-target is up to date.
Changes applied before test
commit 8745da76bb444439560bcf7f3d238705ec2d96d3
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Mon Apr 20 11:53:56 2020 +0200

    setup.cfg: Update the minimum required runtime python3 version
    
    Related to T2367

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/5/ for more details.

olasd requested changes to this revision.Apr 20 2020, 12:11 PM
olasd added a subscriber: olasd.

Until we migrate (all) other setuptools setup() options to setup.cfg, this should be set in setup.py.

This revision now requires changes to proceed.Apr 20 2020, 12:11 PM

I just checked informally, and surprisingly, it seems we don't use any py3.7 feature (except dataclasses in icinga-plugins)

Adapt setup.py instead of setup.cfg

(thanks)

Build is green

Patch application report for D3031 (id=10765)

Rebasing onto dca9c5fc66...

Current branch diff-target is up to date.
Changes applied before test
commit b3138db178af5365325703131cdb7b3611248e61
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Mon Apr 20 11:53:56 2020 +0200

    setup: Update the minimum required runtime python3 version
    
    Related to T2367

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/6/ for more details.

Actually, swh-scanner uses from __future__ import annotations, which was introduced in py3.7.

So you should also patch its setup.py

ardumont retitled this revision from setup.cfg: Update the minimum required runtime python3 version to setup: Update the minimum required runtime python3 version.Apr 20 2020, 12:34 PM
ardumont retitled this revision from setup: Update the minimum required runtime python3 version to core: setup: Update the minimum required runtime python3 version.Apr 20 2020, 12:54 PM
ardumont retitled this revision from core: setup: Update the minimum required runtime python3 version to docs: setup: Update the minimum required runtime python3 version.
ardumont retitled this revision from docs: setup: Update the minimum required runtime python3 version to core: setup: Update the minimum required runtime python3 version.Apr 20 2020, 12:55 PM

Harbormaster failed remote builds in B11898: Diff 10770!

Yes, i messed up the diff by squashing it with 3032's content.

I've updated it back to the right content but somehow can't make it go green again.

Build is green

Patch application report for D3031 (id=10770)

Rebasing onto dca9c5fc66...

Current branch diff-target is up to date.
Changes applied before test
commit b3138db178af5365325703131cdb7b3611248e61
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Mon Apr 20 11:53:56 2020 +0200

    setup: Update the minimum required runtime python3 version
    
    Related to T2367

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/7/ for more details.

I've updated it back to the right content but somehow can't make it go green again.

Found the fix.

Edit the diff's description, change back the associated repository to the right
one.

It became swh-docs instead of swh-core (somehow the last correct `arc diff
update` did not change back to the right repository... ¯\_(ツ)_/¯)

Require python3.7 as it's currently the stable version we are testing against

Build is green

Patch application report for D3031 (id=10776)

Rebasing onto dca9c5fc66...

Current branch diff-target is up to date.
Changes applied before test
commit 5cd847a35d3c59005c40a4e4048b48f8f505c7fa
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Mon Apr 20 11:53:56 2020 +0200

    setup: Update the minimum required runtime python3 version
    
    Related to T2367

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/8/ for more details.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 20 2020, 5:10 PM
This revision was automatically updated to reflect the committed changes.