Page MenuHomeSoftware Heritage
Differential D3003

Rename OBJECT_TYPE_KEYS to TEST_OBJECT_DICTS
ClosedPublic
Actions

Authored by olasd on Apr 10 2020, 12:53 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDJNL1c9ccb29eea3: Rename OBJECT_TYPE_KEYS to TEST_OBJECT_DICTS
Summary

that fixture name was awful

Test Plan

tox

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Apr 10 2020, 12:53 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 10 2020, 12:53 PM
swh-public-ci added a comment.Apr 10 2020, 12:56 PM

Build is green

Patch application report for D3003 (id=10665)

Rebasing onto 750d4c6c5b...

Current branch diff-target is up to date.
Changes applied before test
commit 1c9ccb29eea3b974ea0d3613d61a65cd4e83037b
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Apr 9 18:50:18 2020 +0200

    Rename OBJECT_TYPE_KEYS to TEST_OBJECT_DICTS

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/33/ for more details.

Harbormaster completed remote builds in B11783: Diff 10665.Apr 10 2020, 12:56 PM
olasd added a child revision: D3004: Add a model object based version of the journal writer test objects.Apr 10 2020, 12:58 PM
ardumont accepted this revision.Apr 10 2020, 2:13 PM
This revision is now accepted and ready to land.Apr 10 2020, 2:13 PM
Closed by commit rDJNL1c9ccb29eea3: Rename OBJECT_TYPE_KEYS to TEST_OBJECT_DICTS (authored by olasd). · Explain WhyApr 10 2020, 4:29 PM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDJNL1c9ccb29eea3: Rename OBJECT_TYPE_KEYS to TEST_OBJECT_DICTS.

Revision Contents
Changeset List

PathSize
swh/
journal/
tests/
7 lines
10 lines
42 lines

Diff 10683

View Options

swh/journal/tests/conftest.py

Loading...
View Options

swh/journal/tests/test_kafka_writer.py

Loading...
View Options

swh/journal/tests/test_replay.py

Loading...
About · Developer information · Legal